From owner-svn-src-stable@freebsd.org Thu Dec 31 16:58:13 2015 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98C91A56BB4; Thu, 31 Dec 2015 16:58:13 +0000 (UTC) (envelope-from john@baldwin.cx) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 71A0712D5; Thu, 31 Dec 2015 16:58:13 +0000 (UTC) (envelope-from john@baldwin.cx) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2831CB946; Thu, 31 Dec 2015 11:58:11 -0500 (EST) From: John Baldwin To: Garrett Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r292975 - stable/10/sys/dev/pci Date: Thu, 31 Dec 2015 08:42:51 -0800 Message-ID: <2893860.oDiG4KQizb@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201512310355.tBV3t2VG040656@repo.freebsd.org> References: <201512310355.tBV3t2VG040656@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 31 Dec 2015 11:58:11 -0500 (EST) X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2015 16:58:13 -0000 On Thursday, December 31, 2015 03:55:02 AM Garrett Cooper wrote: > Author: ngie > Date: Thu Dec 31 03:55:02 2015 > New Revision: 292975 > URL: https://svnweb.freebsd.org/changeset/base/292975 > > Log: > MFC r278860: > r278860 (by jmg): > > remove NULL check as M_WAITOK will not return NULL > > Reviewed by: jhb > Sponsored by: FreeBSD Foundation Including the metadata from the HEAD commit in the MFC can be misleading, and I think it is best ommitted. For example, I did not review this MFC (and reviewing MFC's in their own right matters since they may require additional work than commits to HEAD due to ABI concerns), nor did the Foundation sponsor the MFC. Rather, I think MFCs should only specify metadata related to the actual merge itself. -- John Baldwin