From owner-dev-commits-src-all@freebsd.org Tue Feb 2 16:58:09 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 565B25371FF; Tue, 2 Feb 2021 16:58:09 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DVWGS4mrwz3n2N; Tue, 2 Feb 2021 16:58:08 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x42f.google.com with SMTP id 7so21256487wrz.0; Tue, 02 Feb 2021 08:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iu23osRc+lLe3snSX5n69ppFkr1xRLXH6KjcJIqVSf4=; b=nO2lfMF+3tZZ1TzI/BfNGW4v+GSgNoJs3D9dmvKtJvnFwqUHFSEft9dXErR4LXhR1m n4x3fRvh8WbRZ883xWUg4VyD96jXM1tBfbXL2zgp/+C90i6ScuBr7kpAKmpv7Ja/vU1B aqUKS6X3Pohj0dbV8IIjDciOEyjufxU+OE8eDzKwsAY5nfjGDG4wWQ+MWpEayn/DQ7SY h7BVND5UEYM/J9q8kaxSkZwTmGzbZDat/a6tVvCXzt8Ocz8twCeY6iYXcoBhSFN677UX xjToj21QQjCgs1iSq5zB+7iH4+R7sJewhJObD4/TzVjbu4dkKm3ALNtRCVt8+ZgzVTaX OT5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iu23osRc+lLe3snSX5n69ppFkr1xRLXH6KjcJIqVSf4=; b=UrT+emRfMDCzkGON+0azLIdqda4jHlqpYD8OG8yX+iFIB7oUHob1xCOywWIFPlazgY pb1aRx4JKgoDLUiAuBNs/QuL+2ucEWgS73OtXXNE5PU44tSiPss9DCtZ/9i8ut7w4yN7 gVz+R8v7egFEaw1xuL2kFqb5gAfGQ6Kuyh23mH2M8b3qrfmhS10C/apAyYwSGTWGxLr2 4VNV2aOW0Z7W4ET99zXkrgx7D37BWKV+f56pSSzJIQEUPkLcSy3TuMmjE03ez9JU/dMc /dbEH2V1jGXit9W5l3vqZKpj3ijfOFUJ13N/msu7sAc7rqGFDBrN3fu8itkSRd1pUmwB ZBqA== X-Gm-Message-State: AOAM531AtYVioeVJYh0QLX6343RI0NdBvptkGAvrVQN2y+AF6iHJ5TsB vIIGwoImHnGKdc86OlVb4kWZBroJIyi7sExSVBw8p6V8sKIlZA== X-Google-Smtp-Source: ABdhPJygkxtsa4PNhItr7x+TrUaw+/GHJBdFs89kRHwCK6mtNL0I20GPq6oGuEzAdFMSWtH174uEG5Urd/dswwOpZHY= X-Received: by 2002:adf:e511:: with SMTP id j17mr24726115wrm.17.1612285086545; Tue, 02 Feb 2021 08:58:06 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:464c:0:0:0:0:0 with HTTP; Tue, 2 Feb 2021 08:58:05 -0800 (PST) In-Reply-To: References: <202102011240.111CehGE094845@gitrepo.freebsd.org> From: Mateusz Guzik Date: Tue, 2 Feb 2021 17:58:05 +0100 Message-ID: Subject: Re: git: e92ab3adf4f9 - stable/13 - atomic: make atomic_store_ptr type-aware To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DVWGS4mrwz3n2N X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=nO2lfMF+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::42f as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::42f:from]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(1.00)[0.998]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::42f:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::42f:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-branches]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2021 16:58:09 -0000 On 2/2/21, Mateusz Guzik wrote: > I thought I responded to this bit, I did not address the (in my > opinion incorrect) claim that a fence can't be avoided rendering > consume primitive pointless. I have a somewhat reply for this. somewhat longer > > but tl;dr yes, I'll add validation for pointer types > > A bug was reported in the namecache which I want to take care of > before I do other stuff. > > On 2/2/21, John Baldwin wrote: >> On 2/1/21 4:40 AM, Mateusz Guzik wrote: >>> The branch stable/13 has been updated by mjg: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=e92ab3adf4f9848933439c9c2fca36df290c0884 >>> >>> commit e92ab3adf4f9848933439c9c2fca36df290c0884 >>> Author: Mateusz Guzik >>> AuthorDate: 2021-01-25 19:39:14 +0000 >>> Commit: Mateusz Guzik >>> CommitDate: 2021-02-01 12:39:16 +0000 >>> >>> atomic: make atomic_store_ptr type-aware >>> >>> (cherry picked from commit >>> cc96f92a570e05636a20fdd15d4616b127bb9ecc) >> >> A couple of folks expressed concerns about this commit when it landed >> in main due to it being too flexible (it allows you to store pointers >> to non-pointer types, e.g.: >> >> char c; >> uintptr_t p; >> >> atomic_store_ptr(&c, p); >> >> Silently becomes: >> >> atomic_store_char(&c, (char)p); >> >> Are you planning to address this? >> >> -- >> John Baldwin >> > > > -- > Mateusz Guzik > -- Mateusz Guzik