From owner-freebsd-stable@FreeBSD.ORG  Sun Jan 13 16:12:14 2013
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 85390450;
 Sun, 13 Jan 2013 16:12:14 +0000 (UTC)
 (envelope-from markiyan.kushnir@gmail.com)
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180])
 by mx1.freebsd.org (Postfix) with ESMTP id BD015BF0;
 Sun, 13 Jan 2013 16:12:13 +0000 (UTC)
Received: by mail-wi0-f180.google.com with SMTP id hj13so781170wib.7
 for <multiple recipients>; Sun, 13 Jan 2013 08:12:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=x-received:message-id:date:from:user-agent:mime-version:to:cc
 :subject:content-type:content-transfer-encoding;
 bh=zCp+1ttWB41FJpQYpE96JJirx6wUC50vENTp/02CM+8=;
 b=eg2+4QWSu8F9znrWn8poYsMU7OR4geTwrSy2XvRxN9bxw8M8NARDNTb8yjs3P52MCy
 qWAt75/4GqFZHfS21kbShPBJ3XEoxCImJC5eaG1+BtqOWvO5QmQBSYW8HBJFut7bz/sv
 xjnqjI39jveBLUq4ke86e39mzvcn8Vz61OIe5u36/wXfM/lmmc9badz3gkw1ylcYwDLh
 QCv1j4MrZc1tTBZXC8MOZH4+OPhqQJPaUGjfS2SyXibCzhpSo5L/DgybzS9ClRjpSSAD
 fHCrBURzUvvSuwaSwihyrPeMLSzxeZpKax/VIorndyxs9PewrJKKM6sB2t3f6F094SiK
 PkMw==
X-Received: by 10.194.23.37 with SMTP id j5mr130386295wjf.28.1358093532616;
 Sun, 13 Jan 2013 08:12:12 -0800 (PST)
Received: from mkushnir.zapto.org (170-113-132-95.pool.ukrtel.net.
 [95.132.113.170])
 by mx.google.com with ESMTPS id bw9sm8732248wib.5.2013.01.13.08.12.10
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Sun, 13 Jan 2013 08:12:11 -0800 (PST)
Message-ID: <50F2DCA1.8080208@gmail.com>
Date: Sun, 13 Jan 2013 18:11:13 +0200
From: Markiyan Kushnir <markiyan.kushnir@gmail.com>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:16.0) Gecko/20121119 Thunderbird/16.0.2
MIME-Version: 1.0
To: stable@freebsd.org
Subject: VIDIOC_ENUM_FRAMESIZES in linux_ioctl.c
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: nox@freebsd.org, netchild@freebsd.org
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jan 2013 16:12:14 -0000

Hi,

Any reason why LINUX_VIDIOC_ENUM_FRAMESIZES, 
LINUX_VIDIOC_ENUM_FRAMEINTERVALS, LINUX_VIDIOC_ENCODER_CMD, and 
LINUX_VIDIOC_TRY_ENCODER_CMD in compat/linux/linux_ioctl.c have been put 
under #ifdef VIDIOC_ENUM_FRAMESIZES (looks like it's been there since 
rev. 221426, when the v4l2 support was introduced) ?

I've just hit an issue with the current Skypes in the ports tree (both 
2.1.0.81 and 2.2.0.35) trying to call at least the 
LINUX_VIDIOC_ENUM_FRAMESIZES ioctl, so I re-built linux.ko with 
-DVIDIOC_ENUM_FRAMESIZES and found no visible issues on my desktop so 
far beyond that my skype started to send video.

If there is some reason, it would be good to let people know why these 
ioctls are turned off by default.

--
Thanks,
Markiyan.