From owner-svn-src-projects@freebsd.org Wed Dec 16 22:08:48 2015 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F2F8A49D54 for ; Wed, 16 Dec 2015 22:08:48 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 09AAE1431; Wed, 16 Dec 2015 22:08:43 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA04408; Thu, 17 Dec 2015 00:08:40 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1a9KFT-000PaV-Uh; Thu, 17 Dec 2015 00:08:39 +0200 Subject: Re: svn commit: r292353 - projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zfs_set To: Alan Somers , src-committers@FreeBSD.org, svn-src-projects@FreeBSD.org References: <201512161930.tBGJUiTn047536@repo.freebsd.org> From: Andriy Gapon Message-ID: <5671E0AA.1020102@FreeBSD.org> Date: Thu, 17 Dec 2015 00:07:38 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <201512161930.tBGJUiTn047536@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2015 22:08:48 -0000 On 16/12/2015 21:30, Alan Somers wrote: > Author: asomers > Date: Wed Dec 16 19:30:44 2015 > New Revision: 292353 > URL: https://svnweb.freebsd.org/changeset/base/292353 > > Log: > Disable read-only testing of space usage properties. > > These properties (used, available, referenced) are easily influenced by > internal machinations in ZFS, and currently cause random failures of this > test when run on a system running the BP workers. > > The test itself checks that the properties can't be changed, and goes > farther than just asserting that the 'zfs set' command fails: it also checks > that the property's value still matches its original value. > > For some reason, however, background activity causes short-term changes in > these values, that appear not to involve either an ioctl (at least one that > would show up in 'zpool history') or filesystem accesses. This is hopefully > still only temporary just to get the tests passing. > > Submitted by: Will > Sponsored by: Spectra Logic Corp FWIW, hhttps://github.com/avg-I/openzfs/commit/e7a8782eb9ea84e6db92891dfd5a74c655d0a44a The change is a bit lame, but better than nothing. > Modified: > projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zfs_set/ro_props_001_pos.ksh > > Modified: projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zfs_set/ro_props_001_pos.ksh > ============================================================================== > --- projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zfs_set/ro_props_001_pos.ksh Wed Dec 16 19:28:42 2015 (r292352) > +++ projects/zfsd/head/tests/sys/cddl/zfs/tests/cli_root/zfs_set/ro_props_001_pos.ksh Wed Dec 16 19:30:44 2015 (r292353) > @@ -63,11 +63,36 @@ set -A values filesystem volume snapshot > set -A dataset $TESTPOOL $TESTPOOL/$TESTFS $TESTPOOL/$TESTVOL \ > $TESTPOOL/$TESTCTR/$TESTFS1 $TESTPOOL/$TESTFS@$TESTSNAP \ > $TESTPOOL/$TESTVOL@$TESTSNAP > -typeset ro_props="type used available avail creation referenced refer compressratio \ > - mounted origin" > -typeset snap_ro_props="volsize recordsize recsize quota reservation reserv mountpoint \ > - sharenfs checksum compression compress atime devices exec readonly rdonly \ > - setuid" > + > +typeset ro_props="type" > +ro_props="$ro_props creation" > +ro_props="$ro_props compressratio" > +ro_props="$ro_props mounted" > +ro_props="$ro_props origin" > +# Uncomment these once the test ensures they can't be changed. > +#ro_props="$ro_props used" > +#ro_props="$ro_props available" > +#ro_props="$ro_props avail" > +#ro_props="$ro_props referenced" > +#ro_props="$ro_props refer" > + > +typeset snap_ro_props="volsize" > +snap_ro_props="$snap_ro_props recordsize" > +snap_ro_props="$snap_ro_props recsize" > +snap_ro_props="$snap_ro_props quota" > +snap_ro_props="$snap_ro_props reservation" > +snap_ro_props="$snap_ro_props reserv" > +snap_ro_props="$snap_ro_props mountpoint" > +snap_ro_props="$snap_ro_props sharenfs" > +snap_ro_props="$snap_ro_props checksum" > +snap_ro_props="$snap_ro_props compression" > +snap_ro_props="$snap_ro_props compress" > +snap_ro_props="$snap_ro_props atime" > +snap_ro_props="$snap_ro_props devices" > +snap_ro_props="$snap_ro_props exec" > +snap_ro_props="$snap_ro_props readonly" > +snap_ro_props="$snap_ro_props rdonly" > +snap_ro_props="$snap_ro_props setuid" > > $ZFS upgrade -v > /dev/null 2>&1 > if [[ $? -eq 0 ]]; then > @@ -76,6 +101,7 @@ fi > > function cleanup > { > + poolexists $TESTPOOL && log_must $ZPOOL history $TESTPOOL > datasetexists $TESTPOOL/$TESTVOL@$TESTSNAP && \ > destroy_snapshot $TESTPOOL/$TESTVOL@$TESTSNAP > datasetexists $TESTPOOL/$TESTFS@$TESTSNAP && \ > -- Andriy Gapon