From owner-freebsd-bugs@FreeBSD.ORG  Tue Oct 17 01:40:25 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 61BE316A47B
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 17 Oct 2006 01:40:25 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2967A43D5D
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 17 Oct 2006 01:40:25 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k9H1eOae011465
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 17 Oct 2006 01:40:24 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k9H1eOFm011464;
	Tue, 17 Oct 2006 01:40:24 GMT (envelope-from gnats)
Date: Tue, 17 Oct 2006 01:40:24 GMT
Message-Id: <200610170140.k9H1eOFm011464@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Bruce Evans <bde@zeta.org.au>
Cc: 
Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Bruce Evans <bde@zeta.org.au>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Oct 2006 01:40:25 -0000

The following reply was made to PR kern/104436; it has been noted by GNATS.

From: Bruce Evans <bde@zeta.org.au>
To: John Baldwin <jhb@freebsd.org>
Cc: freebsd-hackers@freebsd.org, Cheng-Lung Sung <clsung@freebsd.org>, 
    freebsd-current@freebsd.org, freebsd-bugs@freebsd.org, 
    FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h
Date: Tue, 17 Oct 2006 11:39:09 +1000 (EST)

 [This is still being sent to too many mailing lists since I don't know
   which ones it should go to except gnats.]
 
 On Mon, 16 Oct 2006, John Baldwin wrote:
 
 >> Including sys/types.h would add lots of namespace pollution which
 >> sys/ipc.h and sys/sem.h are trying hard to avoid.   sem.h is trying too
 >> hard -- POSIX requires it to declare time_t (and pid_t, key_t and size_t,
 >> which it already declares).
 >
 > Is this better?
 >
 > Index: sem.h
 > ===================================================================
 > RCS file: /usr/cvs/src/sys/sys/sem.h,v
 > retrieving revision 1.29
 > diff -c -r1.29 sem.h
 > *** sem.h	17 Nov 2004 13:12:06 -0000	1.29
 > --- sem.h	16 Oct 2006 18:30:05 -0000
 > ***************
 > *** 111,116 ****
 > --- 111,121 ----
 >  #define _SIZE_T_DECLARED
 >  #endif
 >
 > + #ifndef _TIME_T_DECLARED
 > + typedef	__time_t	time_t;
 > + #define	_TIME_T_DECLARED
 > + #endif
 > +
 >  #ifndef _PID_T_DECLARED
 >  typedef __pid_t         pid_t;
 >  #define _PID_T_DECLARED
 >
 > (it looks like pid_t should be before size_t in sem.h btw)
 
 Good.  (I didn't check if there are any other missing typedefs.)
 Please commit.
 
 The old typedefs also have non-KNF whitespace.  sys/ipc.h is better.
 
 Bruce