From eugen@grosbein.net Fri Sep 1 06:44:50 2023 X-Original-To: stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RcT7c3Fm1z4s8d4 for ; Fri, 1 Sep 2023 06:45:48 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RcT7c09gqz4fw2 for ; Fri, 1 Sep 2023 06:45:47 +0000 (UTC) (envelope-from eugen@grosbein.net) Authentication-Results: mx1.freebsd.org; none Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.17.1/8.17.1) with ESMTPS id 3816jbJ3004703 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 1 Sep 2023 06:45:38 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: herbert@gojira.at Received: from [10.58.0.11] (dadvw [10.58.0.11] (may be forged)) by eg.sd.rdtc.ru (8.17.1/8.17.1) with ESMTPS id 3816jaCM023132 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 1 Sep 2023 13:45:37 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: net/mpd5 on stable/14 - COMPAT_FREEBSD12 required? To: "Herbert J. Skuhra" , stable@FreeBSD.org References: <871qfkr747.wl-herbert@gojira.at> <87zg28prqx.wl-herbert@gojira.at> <87h6ofkvym.wl-herbert@gojira.at> <87fs3yxvkf.wl-herbert@gojira.at> From: Eugene Grosbein Message-ID: <7b59195f-9902-629e-79e3-8a3ecc2ea161@grosbein.net> Date: Fri, 1 Sep 2023 13:44:50 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 In-Reply-To: <87fs3yxvkf.wl-herbert@gojira.at> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT autolearn=disabled version=3.4.6 X-Spam-Report: * -0.0 SHORTCIRCUIT No description available. * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hz.grosbein.net X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE] X-Rspamd-Queue-Id: 4RcT7c09gqz4fw2 01.09.2023 13:21, Herbert J. Skuhra wrote: > On Thu, 31 Aug 2023 18:39:13 +0200, "Herbert J. Skuhra" wrote: >> >> On Wed, 30 Aug 2023 15:46:46 +0200, "Herbert J. Skuhra" wrote: >>> >>> On Wed, 30 Aug 2023 15:29:28 +0200, "Herbert J. Skuhra" wrote: >>>> >>>> Hi, >>>> >>>> after updating from stable/13 to (main and later to) stable/14 >>>> net/mpd5 only connects to my ISP (VDSL with VLAN) if I enable "options >>>> COMPAT_FREEBSD12" in my kernel. Without I get only: >>>> >>>> Aug 30 15:08:06 gw mpd[59876]: [L1] PPPoE connection timeout after 9 seconds >>>> Aug 30 15:08:06 gw mpd[59876]: [L1] Link: DOWN event >>>> Aug 30 15:08:06 gw mpd[59876]: [L1] LCP: Down event >>>> Aug 30 15:08:06 gw mpd[59876]: [L1] Link: reconnection attempt 1 in 7 seconds >>>> Aug 30 15:08:14 gw mpd[59876]: [L1] Link: reconnection attempt 1 >>>> Aug 30 15:08:14 gw mpd[59876]: [L1] PPPoE: Connecting to '' >>>> Aug 30 15:08:23 gw mpd[59876]: [L1] PPPoE connection timeout after 9 seconds >>>> Aug 30 15:08:23 gw mpd[59876]: [L1] Link: DOWN event >>>> Aug 30 15:08:23 gw mpd[59876]: [L1] LCP: Down event >>>> [..] >>>> >>>> I guess the problem is: >>>> >>>> Without "COMPAT_FREEBSD12" vlanproto = 0x0000. If I run "ifconfig >>>> vlan31 vlanproto 802.1q" mpd5 works. >>> >>> Maybe this commit is related: >>> >>> commit afbb64f1d85b7d8c2938031c3567946b5d10da4f >>> Author: Alexander V. Chernikov >>> Date: Sun Apr 11 17:47:03 2021 +0100 >>> >>> Fix vlan creation for the older ifconfig(8) binaries. >>> >>> Reported by: allanjude >>> MFC after: immediately >>> >>> ? >> >> On stable/13 (GENERIC without COMPAT_FREEBSD12): >> >> # ifconfig vlan99 create >> ==> vlanproto: 0x0000 >> # ifconfig vlan99 vlan 99 vlandev igb0 >> ==> vlanproto: 802.1q >> # ifconfig vlan99 destroy >> # ifconfig vlan99 create vlan 99 vlandev igb0 >> ==> vlanproto: 802.1q >> >> On stable/14 or main (GENERIC without COMPAT_FREEBSD12): >> >> # ifconfig vlan99 create >> ==> vlanproto 0x0000 >> # ifconfig vlan99 vlan 99 vlandev igb0 >> ==> vlanproto 0x0000# >> # ifconfig vlan99 create vlan 99 vlandev igb0 >> ==> vlanproto: 802.1q >> >> I guess that's why the following lines in my /etc/rc.conf no longer >> work on stable/14 or main (without COMPAT_FREEBSD12): >> >> cloned_interfaces="vlan99" >> ifconfig_vlan99="vlan 99 vlandev igb0" >> >> I have to replace the ifconfig line with: >> >> ifconfig_vlan99="vlan 99 vlandev igb0 vlanproto 802.1q" >> >> It also works if I remove the following lines in sys/net/if_vlan.c: >> >> 1110 #ifdef COMPAT_FREEBSD12 >> 1113 #endif >> >> 2265 #ifdef COMPAT_FREEBSD12 >> 2268 #endif > > Bug or user error? Seems to me as a regression in 14.