From owner-freebsd-fs@FreeBSD.ORG  Mon Jul 12 20:06:01 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9D352106566C
	for <freebsd-fs@freebsd.org>; Mon, 12 Jul 2010 20:06:01 +0000 (UTC)
	(envelope-from mavbsd@gmail.com)
Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 248848FC1E
	for <freebsd-fs@freebsd.org>; Mon, 12 Jul 2010 20:06:00 +0000 (UTC)
Received: by bwz12 with SMTP id 12so3142759bwz.13
	for <freebsd-fs@freebsd.org>; Mon, 12 Jul 2010 13:06:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:sender:message-id:date:from
	:user-agent:mime-version:to:subject:references:in-reply-to
	:x-enigmail-version:content-type:content-transfer-encoding;
	bh=mobDwTrg+r/+SMBW53Fj28pWkdzu0o88pOQ3FsnQ9jA=;
	b=nAPPJrlY43odD2IFVj2Y9seoFOb35hlh5a+iXCJ6Szx41jyKFBHAPjL2YyRZUqIn5W
	l+6h8HyBVaYX8bx7J8E1Ezk/CO4vASwA1BkZHVUxlkeCUHBxNIIsQn6HXxVkvZlB6vRZ
	HoWQTfkDEBfLD4LF/IbrBBIeGtlsMbmMfLsR0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=sender:message-id:date:from:user-agent:mime-version:to:subject
	:references:in-reply-to:x-enigmail-version:content-type
	:content-transfer-encoding;
	b=i8n828DV1IBa8zv47WKssBpsP47d3zRjikJuxoafNfgfH92W67iTiWu9UjH+ueekOM
	JbhBtpKuhnLQRnPFhiycHHhRfdrUDDznxLUzxMaegT9XBulY2YjkaNPY0OwOyZ1F62+h
	mnVyge/78vdY2NMaJcFLFaBD62oiiFOzyAu3A=
Received: by 10.204.178.82 with SMTP id bl18mr11041320bkb.118.1278965158299;
	Mon, 12 Jul 2010 13:05:58 -0700 (PDT)
Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226])
	by mx.google.com with ESMTPS id y2sm20007678bkx.8.2010.07.12.13.05.56
	(version=SSLv3 cipher=RC4-MD5); Mon, 12 Jul 2010 13:05:56 -0700 (PDT)
Sender: Alexander Motin <mavbsd@gmail.com>
Message-ID: <4C3B75A1.4020905@FreeBSD.org>
Date: Mon, 12 Jul 2010 23:05:53 +0300
From: Alexander Motin <mav@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.24 (X11/20100402)
MIME-Version: 1.0
To: Mikolaj Golub <to.my.trociny@gmail.com>, freebsd-fs@freebsd.org
References: <mailpost.1278963760.4818474.103.mailing.freebsd.fs@FreeBSD.cs.nctu.edu.tw>
In-Reply-To: <mailpost.1278963760.4818474.103.mailing.freebsd.fs@FreeBSD.cs.nctu.edu.tw>
X-Enigmail-Version: 0.96.0
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: ata-disk.c:ad_init(): max_iosize might be uninitialized?
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jul 2010 20:06:01 -0000

Hi.

Mikolaj Golub wrote:
> It might be a wrong list but I have not found freebsd-ata@ or freebsd-disk@
> list -).
> 
> I just have looked accidentally at ad_init() in dev/ata/ata-disk.c and it
> looks like there is at least theoretical possibility that atadev->max_iosize
> remains uninitialized (if ata_controlcmd(ATA_SET_MULTI) fails). Shouldn't be
> like in the patch below?

It is not very obvious, but it is initialized in ata_add_child().

-- 
Alexander Motin