From owner-freebsd-current  Tue Jun 18 07:14:34 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id HAA28083
          for current-outgoing; Tue, 18 Jun 1996 07:14:34 -0700 (PDT)
Received: from vector.jhs.no_domain (slip139-92-42-140.ut.nl.ibm.net [139.92.42.140])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id HAA28050;
          Tue, 18 Jun 1996 07:14:26 -0700 (PDT)
Received: (from jhs@localhost) by vector.jhs.no_domain (8.7.5/8.6.9) id MAA01844; Tue, 18 Jun 1996 12:14:49 +0200 (MET DST)
Date: Tue, 18 Jun 1996 12:14:49 +0200 (MET DST)
Message-Id: <199606181014.MAA01844@vector.jhs.no_domain>
To: current@freebsd.org
cc: jkh@freebsd.org
Subject: xditview
From: "Julian H. Stacey" <jhs@freebsd.org>
Reply-To: "Julian H. Stacey" <jhs@freebsd.org>
Organization: Vector Systems Ltd.
Address: Holz Strasse 27d, 80469 Munich, Germany
Phone: +49.89.268616
Fax: +49.89.2608126 (later)
Web: http://www.freebsd.org/~jhs/
Mailer: EXMH 1.6.7, PGP available
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

It seems xditview was removed from src/gnu/usr.bin/groff/
(with today's just received ctm patch: src-cur.1896)

I seem to recall someone complaining it wouldnt compile if there was no
X tree resident, could it have been removed just because of that ? !

A better solution may be something like:
src/gnu/usr.bin/groff/Makefile:
	.if exists(${X11BASE}/include)
	.if exists(${X11BASE}/lib)
	SUBDIR +=xditview

Could whoever removed xditview please consider restoring it,
& adding a 	.if exists 	?
Losing functionality seems questionable, as even if net people aren't using
it, at next cd-rom upgrade, it'll likely sting some non-net users.
(& BTW I guess it's good to remember: Those silent non code contributing
FreeBSD users are still useful, as customers of WC & FreeBSD consultants :-) )


PS I detected this as ctm reported "md5 mismatch" as 
I had the following patch in use: 
	http://www.freebsd.org/~jhs/src/bsd/fixes/FreeBSD/src/generic/gnu/usr.bin/groff/xditview/Makefile.DESTDIR.diff
==============
If you happen to compile with something like
	DESTDIR=/usr/dest//usr2/data/freebsd/src.940225
& that DESTDIR has no X386 tree, it doesnt compile.
If you later say, "yes that compiled clean, Im happy, install in /"
(which does have an X tree)
	setenv DESTDIR /
	make install
it blows up because it never compiled !

Solution:
	compile on one set of if's
	install on a larger set of if's

*** old/src/gnu/usr.bin/groff/xditview/Makefile	Sat Dec  3 19:40:18 1994
--- new/src/gnu/usr.bin/groff/xditview/Makefile	Sat Dec  3 19:44:23 1994
***************
*** 1,8 ****
  .if exists(${X11BASE}/include)
  .if exists(${X11BASE}/lib)
- .if exists(${DESTDIR}${X11BASE}/bin)
- .if exists(${DESTDIR}${X11BASE}/man/man1)
- .if exists(${DESTDIR}${X11BASE}/lib/X11/app-defaults)
  
  BINDIR=		${X11BASE}/bin
  MANDIR=		${X11BASE}/man/man
--- 1,5 ----
***************
*** 17,22 ****
--- 14,22 ----
  		${X11BASE}/lib/libXt.a ${X11BASE}/lib/libXext.a \
  		${X11BASE}/lib/libX11.a
  
+ .if exists(${DESTDIR}${X11BASE}/bin)
+ .if exists(${DESTDIR}${X11BASE}/man/man1)
+ .if exists(${DESTDIR}${X11BASE}/lib/X11/app-defaults)
  afterinstall:
  		install -c -o ${BINOWN} -g ${BINGRP} -m 444 \
  		${.CURDIR}/GXditview.ad \
==============

Julian
--
Julian H. Stacey	jhs@freebsd.org		http://www.freebsd.org/~jhs/