Date: Tue, 22 Jan 2019 11:09:11 +0100 From: Christoph Moench-Tegeder <cmt@burggraben.net> To: Jan Beich <jbeich@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r490910 - in head: Mk Mk/Uses mail/thunderbird www/firefox www/firefox-esr www/firefox-i18n www/firefox/files www/palemoon www/seamonkey Message-ID: <20190122100911.GA77378@elch.exwg.net> In-Reply-To: <o989-8nt8-wny@FreeBSD.org> References: <201901212303.x0LN3jR3059519@repo.freebsd.org> <CAGBxaX=T7SvB6Ncm-0Drt1-HLED92xKuJ-LRvg%2BYsDFKrYCp4A@mail.gmail.com> <CAGBxaXmOibxw_q5Ev34oyiCetNRqNVLNY5VjQrJZFEFTy6nDhg@mail.gmail.com> <o989-8nt8-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Excuse my hijacking of this thread... firefox 65 fails to build (poudirere, amd64, 12.0) when option WAYLAND is disabled (that't not the default), first error is: : In file included from /wrkdirs/usr/ports/www/firefox/work/.build/gfx/webrender_bindings/Unified_cpp_webrender_bindings0.cpp:20: : /wrkdirs/usr/ports/www/firefox/work/firefox-65.0/gfx/webrender_bindings/RenderCompositor.cpp:35:47: error: use of undeclared identifier 'RenderCompositorEGL'; did you mean 'RenderCompositorOGL'? : UniquePtr<RenderCompositor> eglCompositor = RenderCompositorEGL::Create(aWidget); : ^~~~~~~~~~~~~~~~~~~ : RenderCompositorOGL Looking at patch-bug1514156 with perfect hindsight, that's somewhat obvious as the include of RenderCompositorEGL.h is guarded with an #ifdef MOZ_WAYLAND (line 20 of RenderCompositor.cpp), but the first use of RenderCompositorEGL (line 35, see above) is wrapped in an #ifdef MOZ_WIDGET_GTK. Having changed some OPTIONS, the build bombs out in a different way while I'm writing this... I'll have to investigate, because in my hopeleslsy optimistic way I changed more than one option at once. Regards, Christoph -- Spare Space
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190122100911.GA77378>