From owner-svn-src-head@freebsd.org  Tue Aug 14 15:28:10 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA4E1107B7D8;
 Tue, 14 Aug 2018 15:28:10 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 37F6574A62;
 Tue, 14 Aug 2018 15:28:09 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w7EFS88D042921;
 Tue, 14 Aug 2018 08:28:08 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w7EFS8db042920;
 Tue, 14 Aug 2018 08:28:08 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201808141528.w7EFS8db042920@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r337758 - head/sys/x86/x86
In-Reply-To: <201808141450.w7EEo78r029739@repo.freebsd.org>
To: Mark Johnston <markj@freebsd.org>
Date: Tue, 14 Aug 2018 08:28:08 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Aug 2018 15:28:10 -0000

> Author: markj
> Date: Tue Aug 14 14:50:06 2018
> New Revision: 337758
> URL: https://svnweb.freebsd.org/changeset/base/337758
> 
> Log:
>   Explain why we aren't using memcpy().
>   
>   Reported by:	jmg
>   X-MFC with:	r337715
>   Sponsored by:	The FreeBSD Foundation
> 
> Modified:
>   head/sys/x86/x86/ucode.c
> 
> Modified: head/sys/x86/x86/ucode.c
> ==============================================================================
> --- head/sys/x86/x86/ucode.c	Tue Aug 14 14:19:57 2018	(r337757)
> +++ head/sys/x86/x86/ucode.c	Tue Aug 14 14:50:06 2018	(r337758)
> @@ -344,6 +344,7 @@ ucode_load_bsp(uintptr_t free)
>  		match = loader->match(fileaddr, &len);
>  		if (match != NULL) {
>  			addr = map_ucode(free, len);
> +			/* We can't use memcpy() before ifunc resolution. */

NVM my previous email, and thank you.

>  			for (i = 0; i < len; i++)
>  				addr[i] = match[i];
>  			match = addr;

-- 
Rod Grimes                                                 rgrimes@freebsd.org