From owner-svn-src-all@freebsd.org Tue Dec 1 10:10:19 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 894D34A47BD; Tue, 1 Dec 2020 10:10:19 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CldBy4DkXz3HmW; Tue, 1 Dec 2020 10:10:18 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id BED2A26020A; Tue, 1 Dec 2020 11:10:16 +0100 (CET) Subject: Re: svn commit: r367714 - head/sys/kern To: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202011160312.0AG3CLcm073334@repo.freebsd.org> From: Hans Petter Selasky Message-ID: <0af338b8-0696-3093-3bd9-8b3ea7207c17@selasky.org> Date: Tue, 1 Dec 2020 11:10:07 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <202011160312.0AG3CLcm073334@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CldBy4DkXz3HmW X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-3.27 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[88.99.82.50:from]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_ZRD(0.00)[88.99.82.50:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.966]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2020 10:10:19 -0000 On 11/16/20 4:12 AM, Mateusz Guzik wrote: > Author: mjg > Date: Mon Nov 16 03:12:21 2020 > New Revision: 367714 > URL: https://svnweb.freebsd.org/changeset/base/367714 > > Log: > select: call seltdfini on process and thread exit > > Since thread_zone is marked NOFREE the thread_fini callback is never > executed, meaning memory allocated by seltdinit is never released. > > Adding the call to thread_dtor is not sufficient as exiting processes > cache the main thread. > > Modified: > head/sys/kern/kern_exit.c > head/sys/kern/kern_thread.c > > Modified: head/sys/kern/kern_exit.c > ============================================================================== > --- head/sys/kern/kern_exit.c Mon Nov 16 03:09:18 2020 (r367713) > +++ head/sys/kern/kern_exit.c Mon Nov 16 03:12:21 2020 (r367714) > @@ -355,6 +355,7 @@ exit1(struct thread *td, int rval, int signo) > PROC_UNLOCK(p); > > umtx_thread_exit(td); > + seltdfini(td); > > /* > * Reset any sigio structures pointing to us as a result of > > Modified: head/sys/kern/kern_thread.c > ============================================================================== > --- head/sys/kern/kern_thread.c Mon Nov 16 03:09:18 2020 (r367713) > +++ head/sys/kern/kern_thread.c Mon Nov 16 03:12:21 2020 (r367714) > @@ -329,6 +329,7 @@ thread_ctor(void *mem, int size, void *arg, int flags) > audit_thread_alloc(td); > #endif > umtx_thread_alloc(td); > + MPASS(td->td_sel == NULL); > return (0); > } > > @@ -369,6 +370,7 @@ thread_dtor(void *mem, int size, void *arg) > osd_thread_exit(td); > td_softdep_cleanup(td); > MPASS(td->td_su == NULL); > + seltdfini(td); > } > > /* > @@ -405,7 +407,7 @@ thread_fini(void *mem, int size) > turnstile_free(td->td_turnstile); > sleepq_free(td->td_sleepqueue); > umtx_thread_fini(td); > - seltdfini(td); > + MPASS(td->td_sel == NULL); > } > > /* Hi, The following panic() has been observed after this change: panic: Assertion mtx_unowned(m) failed at /usr/src/sys/kern/kern_mutex:1181 cpuid = 6 .... panic() _mtx_destroy() seltdfini() exit1() postsig() ast() doreti_ast() --HPS