From owner-freebsd-net@freebsd.org Wed Oct 28 17:02:10 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1873144B5F9 for ; Wed, 28 Oct 2020 17:02:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CLvxs6yvfz4MCY for ; Wed, 28 Oct 2020 17:02:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id EF1DF44B71B; Wed, 28 Oct 2020 17:02:09 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EEE1C44B6C9 for ; Wed, 28 Oct 2020 17:02:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLvxs61Z0z4Lnh for ; Wed, 28 Oct 2020 17:02:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 99D5B1F88A for ; Wed, 28 Oct 2020 17:02:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 09SH29FT000493 for ; Wed, 28 Oct 2020 17:02:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 09SH29d5000492 for net@FreeBSD.org; Wed, 28 Oct 2020 17:02:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 248652] iflib: netmap pkt-gen large TX performance difference between 11-STABLE and 12-STABLE/CURRENT on ix & ixl NIC Date: Wed, 28 Oct 2020 17:02:09 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: iflib, needs-qa, performance, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: sg@efficientip.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: vmaffione@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback? mfc-stable12? mfc-stable11- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 17:02:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248652 --- Comment #43 from Sylvain Galliano --- I made same tests on vmware + vmxnet NIC + latest patch and I got a panic: spin lock 0xfffff80003079cc0 (turnstile lock) held by 0xfffffe0009607e00 (t= id 100006) too long panic: spin lock held too long cpuid =3D 1 time =3D 1603884508 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe0008480= 680 vpanic() at vpanic+0x182/frame 0xfffffe00084806d0 panic() at panic+0x43/frame 0xfffffe0008480730 _mtx_lock_indefinite_check() at _mtx_lock_indefinite_check+0x64/frame 0xfffffe0008480740 _mtx_lock_spin_cookie() at _mtx_lock_spin_cookie+0xd5/frame 0xfffffe0008480= 7b0 turnstile_trywait() at turnstile_trywait+0xe3/frame 0xfffffe00084807e0 __mtx_lock_sleep() at __mtx_lock_sleep+0x119/frame 0xfffffe0008480870 doselwakeup() at doselwakeup+0x179/frame 0xfffffe00084808c0 nm_os_selwakeup() at nm_os_selwakeup+0x13/frame 0xfffffe00084808e0 netmap_notify() at netmap_notify+0x3d/frame 0xfffffe0008480900 softclock_call_cc() at softclock_call_cc+0x13d/frame 0xfffffe00084809a0 callout_process() at callout_process+0x1c0/frame 0xfffffe0008480a10 handleevents() at handleevents+0x188/frame 0xfffffe0008480a50 timercb() at timercb+0x24e/frame 0xfffffe0008480aa0 lapic_handle_timer() at lapic_handle_timer+0x9b/frame 0xfffffe0008480ad0 Xtimerint() at Xtimerint+0xb1/frame 0xfffffe0008480ad0 --- interrupt, rip =3D 0xffffffff80f5bd46, rsp =3D 0xfffffe0008480ba0, rbp = =3D 0xfffffe0008480ba0 --- acpi_cpu_c1() at acpi_cpu_c1+0x6/frame 0xfffffe0008480ba0 acpi_cpu_idle() at acpi_cpu_idle+0x2eb/frame 0xfffffe0008480bf0 cpu_idle_acpi() at cpu_idle_acpi+0x3e/frame 0xfffffe0008480c10 cpu_idle() at cpu_idle+0x9f/frame 0xfffffe0008480c30 sched_idletd() at sched_idletd+0x2e4/frame 0xfffffe0008480cf0 fork_exit() at fork_exit+0x7e/frame 0xfffffe0008480d30 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0008480d30 --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- I used the first patch you sent (Draft patch to test the netmap tx timer), = no issue this time. the only major difference I can see between 2 patches (except sysctl) is: + txq->ift_timer.c_cpu =3D cpu; and + txq->ift_netmap_timer.c_cpu =3D cpu; --=20 You are receiving this mail because: You are on the CC list for the bug.=