From owner-freebsd-usb@FreeBSD.ORG  Fri Jul  4 21:38:16 2008
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B8797106564A;
	Fri,  4 Jul 2008 21:38:16 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129])
	by mx1.freebsd.org (Postfix) with ESMTP id 750158FC17;
	Fri,  4 Jul 2008 21:38:16 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id EB33D73087; Fri,  4 Jul 2008 23:39:59 +0200 (CEST)
Date: Fri, 4 Jul 2008 23:39:59 +0200
From: Luigi Rizzo <rizzo@icir.org>
To: Hans Petter Selasky <hselasky@c2i.net>
Message-ID: <20080704213959.GA1706@onelab2.iet.unipi.it>
References: <20080703140719.GA72315@onelab2.iet.unipi.it>
	<20080703170700.3b91b8c6@peedub.jennejohn.org>
	<20080703152551.GA73103@onelab2.iet.unipi.it>
	<200807042333.17859.hselasky@c2i.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200807042333.17859.hselasky@c2i.net>
User-Agent: Mutt/1.4.2.3i
Cc: usb@freebsd.org, freebsd-current@freebsd.org,
	Gary Jennejohn <gary.jennejohn@freenet.de>, current@freebsd.org
Subject: Re: may I commit this small umodem patch ?
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jul 2008 21:38:16 -0000

On Fri, Jul 04, 2008 at 11:33:15PM +0200, Hans Petter Selasky wrote:
> On Thursday 03 July 2008, Luigi Rizzo wrote:
> > On Thu, Jul 03, 2008 at 05:07:00PM +0200, Gary Jennejohn wrote:
> > > On Thu, 3 Jul 2008 16:07:19 +0200
> > >
> > > Luigi Rizzo <rizzo@icir.org> wrote:
> > > > There was a discussion back in september about adding
> > > > support for basic CDC tty devices in umodem.c.
> > > > This lets you talk to a number of usb devices built around
> > > > microcontrollers (e.g. Atmel), and puts us on par with
> > > > Linux and Windows in terms of supporting these devices.
> > > >
> > > > Because this simply requires the small patch below to the
> > > > probe/attach routine, so if there are no objections I plan to add
> > > > this to the system (CURRENT then RELENG_7 and RELENG_6) in the next
> > > > few days.
> 
> What about flow control? Is flow control required for these devices?

the ones I am talking about don't implement any form of flow control.
I suppose they would otherwise match the previous check.

luigi