From owner-freebsd-bugs@freebsd.org Mon Nov 23 00:21:57 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4DC2047A0AA for ; Mon, 23 Nov 2020 00:21:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CfSWn1Yj4z4dxl for ; Mon, 23 Nov 2020 00:21:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 357E7479F4E; Mon, 23 Nov 2020 00:21:57 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 35438479EEA for ; Mon, 23 Nov 2020 00:21:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CfSWn0znXz4dxk for ; Mon, 23 Nov 2020 00:21:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1521C2361C for ; Mon, 23 Nov 2020 00:21:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0AN0LuCl045797 for ; Mon, 23 Nov 2020 00:21:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0AN0LuvR045782 for bugs@FreeBSD.org; Mon, 23 Nov 2020 00:21:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 251320] vfs_domount_first: do not crash on mount failure Date: Mon, 23 Nov 2020 00:21:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ztong0001@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2020 00:21:57 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251320 Bug ID: 251320 Summary: vfs_domount_first: do not crash on mount failure Product: Base System Version: 12.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: ztong0001@gmail.com Created attachment 219896 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D219896&action= =3Dedit patch vfs_write_suspend_umnt() expect a non-zero vfs_write_suspend_umnt, otherwise it will panic, however in vfs_domount_first(), the counter is zero when calling VFS_UNMOUNT() panic: vn_finished_write: neg cnt cpuid =3D 7 time =3D 1606004193 KDB: stack backtrace: #0 0xffffffff80c0a8f5 at kdb_backtrace+0x65 freebsd#1 0xffffffff80bbeb1b at vpanic+0x17b freebsd#2 0xffffffff80bbe993 at panic+0x43 freebsd#3 0xffffffff80c9da05 at vn_finished_write+0xc5 freebsd#4 0xffffffff80c9f726 at vfs_write_suspend_umnt+0x16 freebsd#5 0xffffffff80ecdd31 at ffs_unmount+0x71 freebsd#6 0xffffffff80c844dd at vfs_domount+0xc0d freebsd#7 0xffffffff80c83228 at vfs_donmount+0x988 freebsd#8 0xffffffff80c82871 at sys_nmount+0x71 freebsd#9 0xffffffff810904c7 at amd64_syscall+0x387 freebsd#10 0xffffffff8106785e at fast_syscall_common+0xf8 Uptime: 2h10m11s --=20 You are receiving this mail because: You are the assignee for the bug.=