From owner-freebsd-bugs Mon Aug 12 16:10:11 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 494FF37B405 for ; Mon, 12 Aug 2002 16:10:06 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E90143E65 for ; Mon, 12 Aug 2002 16:10:05 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7CNA4JU038136 for ; Mon, 12 Aug 2002 16:10:04 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7CNA4xh038135; Mon, 12 Aug 2002 16:10:04 -0700 (PDT) Date: Mon, 12 Aug 2002 16:10:04 -0700 (PDT) Message-Id: <200208122310.g7CNA4xh038135@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Tony Finch Subject: Re: bin/41583: assorted mtree bugs (+fixes) Reply-To: Tony Finch Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/41583; it has been noted by GNATS. From: Tony Finch To: mike@cs.utah.edu Cc: freebsd-gnats-submit@freebsd.org Subject: Re: bin/41583: assorted mtree bugs (+fixes) Date: Tue, 13 Aug 2002 00:09:04 +0100 Mike Hibler wrote: > >1. Cannot handle filenames which start with '#'. > This one has been reported before (bin/35226, bin/41246). My "fix" is different > than the one in 35226, I just added the '-N' option which says: when creating a > spec, don't ever produce comments and when reading a spec, don't expect > comments. The aforementioned fix is probably better than mine. > >2. Cannot handle symlink values with non-standard chars. > This one has also been reported/fixed previously (bin/35454). > My fix is essentially the same. NetBSD has an improved version of strvis() which their mtree() uses, which we should perhaps have a closer look at. I looked at it recently, and I think it fixes your problem #1 (at the expense of backslash-escaping hashes everywhere) but it doesn't fix #2 -- but that should be easy to do. Tony. -- f.a.n.finch http://dotat.at/ FAIR ISLE SOUTH FAEROES: SOUTHERLY OR SOUTHWESTERLY 4 OR 5, OCCASIONALLY 6, BECOMING VARIABLE 3 IN SOUTHEAST FAIR ISLE. RAIN OR SHOWERS. MODERATE OR GOOD. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message