From owner-svn-src-all@FreeBSD.ORG  Wed Jun 20 09:28:33 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DDA421065686;
	Wed, 20 Jun 2012 09:28:33 +0000 (UTC)
	(envelope-from phk@phk.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 9705D8FC08;
	Wed, 20 Jun 2012 09:28:33 +0000 (UTC)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 6CC2D3B763;
	Wed, 20 Jun 2012 09:28:27 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.5/8.14.5) with ESMTP id q5K9SPrL070850;
	Wed, 20 Jun 2012 09:28:25 GMT (envelope-from phk@phk.freebsd.dk)
To: Gennady Proskurin <gprspb@mail.ru>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 20 Jun 2012 11:41:01 +0400."
	<20120620074101.GA832@gpr.nnz-home.ru>
Content-Type: text/plain; charset=ISO-8859-1
Date: Wed, 20 Jun 2012 09:28:25 +0000
Message-ID: <70849.1340184505@critter.freebsd.dk>
Cc: svn-src-head@freebsd.org, Daniel O'Connor <doconnor@gsoft.com.au>,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r237223 - head/sys/dev/fb
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2012 09:28:34 -0000

In message <20120620074101.GA832@gpr.nnz-home.ru>, Gennady Proskurin writes:

>> >> If size is odd, this does not copy the last byte. Not sure, whether =
>> >this is intended.
>> 
>> Feel free to improve...

It is not my impression that an odd byte count can happen at all...

And yes, I fully agree with Bruce that it is a mess, so with "improve"
I didn't mean "bandaid for non-existent issues" I meant: Rewrite with
extreme prejudice.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.