From owner-freebsd-ports@FreeBSD.ORG  Sat May 30 16:18:17 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6EE4F1065670;
	Sat, 30 May 2009 16:18:17 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211])
	by mx1.freebsd.org (Postfix) with ESMTP id 0AC888FC20;
	Sat, 30 May 2009 16:18:17 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 2F0381CD94; Sat, 30 May 2009 18:18:16 +0200 (CEST)
Date: Sat, 30 May 2009 18:18:16 +0200
From: Ed Schouten <ed@80386.nl>
To: Mel Flynn <mel.flynn+fbsd.ports@mailing.thruhere.net>
Message-ID: <20090530161816.GU48776@hoeg.nl>
References: <20090529123633.GM48776@hoeg.nl> <4A213F84.1000704@FreeBSD.org>
	<20090530142152.GS48776@hoeg.nl>
	<200905301805.15180.mel.flynn+fbsd.ports@mailing.thruhere.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="2z7AKWNQ4hR/M4ga"
Content-Disposition: inline
In-Reply-To: <200905301805.15180.mel.flynn+fbsd.ports@mailing.thruhere.net>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: gerald@freebsd.org, Gabor Kovesdan <gabor@freebsd.org>,
	freebsd-ports@freebsd.org
Subject: Re: [Patch] Proposal: USE_GNU89 switch
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 May 2009 16:18:17 -0000


--2z7AKWNQ4hR/M4ga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Mel Flynn <mel.flynn+fbsd.ports@mailing.thruhere.net> wrote:
> Are there any edge cases of (antiquated) ports that (indirectly) use=20
> bsd.sys.mk and as such get hit by:
>     11  # the default is gnu99 for now
>     12  CSTD            ?=3D gnu99
>=20
> In other words should one clean CFLAGS of -std before applying the
> forced one, similar as to what WITH_DEBUG in ports does for -O*.

Yes. This should fix it:

--- bsd.port.mk
+++ bsd.port.mk
@@ -2180,6 +2180,10 @@
 .endif
 .endif
=20
+.if defined(USE_CSTD)
+CFLAGS:=3D	${CFLAGS:N-std=3D*} -std=3D${USE_CSTD}
+.endif
+
 # Multiple make jobs support
 .if defined(DISABLE_MAKE_JOBS) || defined(MAKE_JOBS_UNSAFE)
 _MAKE_JOBS=3D		#

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--2z7AKWNQ4hR/M4ga
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkohXEgACgkQ52SDGA2eCwWoIQCeO+2iYqlftQRjVNKadFm2o8Vb
JKEAnizh6nUO8CaSL91mdUB7mMjleV/f
=RIXW
-----END PGP SIGNATURE-----

--2z7AKWNQ4hR/M4ga--