From owner-freebsd-arch@FreeBSD.ORG Wed Apr 19 22:09:57 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 95F6416A401 for ; Wed, 19 Apr 2006 22:09:57 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1416843D45 for ; Wed, 19 Apr 2006 22:09:57 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (fxpdsxwnubp1rdjk@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k3JM9qhm089366; Wed, 19 Apr 2006 15:09:52 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k3JM9pQa089365; Wed, 19 Apr 2006 15:09:51 -0700 (PDT) (envelope-from jmg) Date: Wed, 19 Apr 2006 15:09:51 -0700 From: John-Mark Gurney To: "M. Warner Losh" Message-ID: <20060419220951.GP38619@funkthat.com> Mail-Followup-To: "M. Warner Losh" , arch@freebsd.org References: <20060419.160002.119566576.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060419.160002.119566576.imp@bsdimp.com> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: arch@freebsd.org Subject: Re: Review request X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 22:09:57 -0000 Warner Losh wrote this message on Wed, Apr 19, 2006 at 16:00 -0600: > The following patches I think will properly set r_rid in struct > resource_i *. Right now, these values are neither used nor set (apart > from some code in my recently committed ARM support for the Atmel > AT91RM9200). However, there's some desire for it to be valid. > > I believe that the following patches makes it valid. Please review > these patches. I'd like to commit them soon: > http://people.freebsd.org/~imp/set_rid.diff Did you mean to if 0 out some code in i386/i386/nexus.c? other than that, looks good... Note: This ties into the message I just posted Re: remove rid pointer (but not rid)... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."