From owner-freebsd-current@FreeBSD.ORG Mon Dec 17 07:17:41 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B48E9E05; Mon, 17 Dec 2012 07:17:41 +0000 (UTC) (envelope-from mr.kodiak@gmail.com) Received: from mail-ia0-f182.google.com (mail-ia0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 552348FC0A; Mon, 17 Dec 2012 07:17:40 +0000 (UTC) Received: by mail-ia0-f182.google.com with SMTP id x2so5046990iad.13 for ; Sun, 16 Dec 2012 23:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=Mt2na8ZSY6K5r85sqgLAITj+r4lyr2SDRiUEsdE8a6w=; b=Frhzy9aOce2oxvuHB4uOdfxrWWbtZrTwt/iVleUm8lj7xWYJ94x+ulg6bwJvZ2liOJ eDMTDOCbHCSG1jKDVw/daD4z8nSnpDbf97kcHRRe7NTRMiVLDhGqM6UlyrJUx+K9a/gu tK73qkmX0AlkXxKwDAV+FBDqvEmZ3olF83SEZ/y+IyDBOCvO+NOfHu/HIgoBovTqwAxH ErbJ2OrryPceB7PawOPS53B1DOE8kh2M5iMzYzyJxSS02wqB0N9WFDTvKAQ23bJnqutv vZCrCFxF43YVqE8A2Tt+At+PIOAxxH2qeXofylsv2ZfRJDaVf2xwlvIxkHYuz/GxXfSk 5+pA== Received: by 10.50.41.225 with SMTP id i1mr8207144igl.73.1355728660652; Sun, 16 Dec 2012 23:17:40 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.41.133 with HTTP; Sun, 16 Dec 2012 23:17:10 -0800 (PST) In-Reply-To: References: From: Bryan Venteicher Date: Mon, 17 Dec 2012 01:17:10 -0600 X-Google-Sender-Auth: 0s6BKhMYHZ2VcwmMSGZgEubGi-U Message-ID: Subject: Re: VirtIO in GENERIC To: Jim Harris Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2012 07:17:41 -0000 On Sun, Dec 16, 2012 at 11:06 PM, Jim Harris wrote: > > > On Sun, Dec 16, 2012 at 6:53 PM, Andrew Thompson > wrote: >> >> On 17 December 2012 13:17, Bryan Venteicher wrote: >> >> > There's been lots of requests to have VirtIO in GENERIC for i386 and >> > amd64. Anybody have any issues or concerns with this or the patch at >> > [1]. This also removes the kludge that was introduced in r239009. >> > >> > I've compiled LINT for i386 and amd64 so hopefully there won't be any >> > surprise breakages. >> > >> > [1] http://people.freebsd.org/~bryanv/patches/virtio.generic.patch >> >> >> It would be great to have the drivers enabled. You do not need the >> sys/conf/files changes, the common and arch files are combined. >> > > Removing the virtio files from sys/conf/files ensures these drivers can only > be specified in x86 kernel configuration files. r239009 added these lines > to sys/conf/files, but Bryan's patch does it more correctly. > > The only question I have is the GENERIC changes where "device virtio" is > added - it says it is required, but should this instead say it's required > for any of the other drivers in this section? > Yes, that wording could be improved; will update the patch in the morning. > -Jim >