From owner-svn-src-head@freebsd.org Tue Feb 28 20:23:27 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0976DCF2EC4; Tue, 28 Feb 2017 20:23:27 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B70BFC30; Tue, 28 Feb 2017 20:23:26 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id ioItcUaRukevuioIvcTatR; Tue, 28 Feb 2017 13:23:25 -0700 X-Authority-Analysis: v=2.2 cv=BLbDlBYG c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=n2v9WMKugxEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=eZJB0bVEOwotBFmLijgA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 492E24AC; Tue, 28 Feb 2017 12:23:23 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v1SKNM9o091732; Tue, 28 Feb 2017 12:23:22 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201702282023.v1SKNM9o091732@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: Scott Long , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314399 - head/sys/sys In-Reply-To: Message from Cy Schubert of "Tue, 28 Feb 2017 12:16:22 -0800." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 28 Feb 2017 12:23:22 -0800 X-CMAE-Envelope: MS4wfIxvBrXtDwVVwB9eZ7gomNFU9L60Juu2eTG8sYVjrbQsDySL8IzZjVU1FsCYgjCQazd9TMAsX5Vk8E+r0zimCmbqhuj0VwlpjDQoMVC56XQuTcSPGecj pyreCY+P0LT1dLtDemFjBsyPlx47YaaQgpDY6lYNHzsiEtDir1+vW9XF0pAKjvAlk2FpilbXr6SAtfWZQkBrCrfinfbLh4KWxpjY+nTlLlMH56IH79PeK1GU 52+rXjaFNfktHznoxaVsljmPtXPb/aEjoSr0KVXLTXLni5ENqkWKOkQOIS8IQ5Cw X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 20:23:27 -0000 Cy Schubert writes: > In message <201702281901.v1SJ1xKE089703@repo.freebsd.org>, Scott Long > writes: > > Author: scottl > > Date: Tue Feb 28 19:01:59 2017 > > New Revision: 314399 > > URL: https://svnweb.freebsd.org/changeset/base/314399 > > > > Log: > > Add prototype for sbuf_putbuf() > > > > Sponsored by: Netflix > > > > Modified: > > head/sys/sys/sbuf.h > > > > Modified: head/sys/sys/sbuf.h > > =========================================================================== > == > > = > > --- head/sys/sys/sbuf.h Tue Feb 28 18:48:12 2017 (r314398) > > +++ head/sys/sys/sbuf.h Tue Feb 28 19:01:59 2017 (r314399) > > @@ -99,6 +99,7 @@ void sbuf_start_section(struct sbuf *, > > ssize_t sbuf_end_section(struct sbuf *, ssize_t, size_t, int); > > void sbuf_hexdump(struct sbuf *, const void *, int, const c > har *, > > int); > > +void sbuf_putbuf(struct sbuf *); > > > > #ifdef _KERNEL > > struct uio; > > > > > > Hi Scott, > > This causes, > > /opt/src/svn-current/lib/libsbuf/../../sys/kern/subr_prf.c:1243:2: error: > implicitly declaring library function 'printf' with type 'int (const char > *, ...)' [-Werror,-Wimplicit-function-declaration] > printf("%s", sbuf_data(sb)); > ^ > /opt/src/svn-current/lib/libsbuf/../../sys/kern/subr_prf.c:1243:2: note: > include the header or explicitly provide a declaration for > 'printf' > 1 error generated. > *** [subr_prf.pico] Error code 1 > > make[4]: stopped in /opt/src/svn-current/lib/libsbuf > 1 error > > > ... and the fix... > > Index: sys/kern/subr_prf.c > =================================================================== > --- sys/kern/subr_prf.c (revision 314404) > +++ sys/kern/subr_prf.c (working copy) > @@ -60,6 +60,8 @@ > #include > #include > #include > +#else > +#include > #endif > #include > #include I picked the wrong one in exmh. This should be for r314397 instead. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.