From nobody Tue Dec 9 16:33:01 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dQkt648BTz6J8pg for ; Tue, 09 Dec 2025 16:33:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dQkt62rr9z3GvZ for ; Tue, 09 Dec 2025 16:33:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765297982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YYrPdYm7KyV3eGTXriQwzbjIoApyBeyaSJTiBooMpIY=; b=yN5hu7Cco++vW1svp3ZWRaAmZrUnL12MkQt0i+WgLcb+AwWeBDyqRBNzpdh6erSMIRUwLo ErM3WdAzIWpdC8TmVKhNrK3tTyY+b1Mh9UyvaiM/TIxwQ2d8K+FdkMgQ7RU8nyRm6qr5x3 ikYjEuQv1XPOqDAwdTgaqfG9sEnpsZ7oxu2TjWD7c9j7bnemlBQLnexiuUNQkeHIrIDbEK HD0b0wC/zjVqqRUhRqEwVPHS3qLx+P/5IEgUKXgNxR4ULOl74nfsPOHGoxP3JJ1DsInpPI EpxgpUaTMggZB97moDq65zHXG53VrapE9Cdny7cXJeV52jG7YL7/j3SkGR31Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765297982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YYrPdYm7KyV3eGTXriQwzbjIoApyBeyaSJTiBooMpIY=; b=EVpAfysUvGWKxNvwvpveVRPMR6qZP16BAdAuSs5+VxzZUxydCySjxD8obREiSU3nVAR4M9 hyM0UXZACUlidMjlFrC42xa+DHrB3imIePpxwY1qbys8VZBGs27XpA05z8rC9AhKWfaU73 xqRmhP57MEQ1eLfnORrOwGcbn/dLOVoFMULkqkrqmG2oyfkx4H9nVQIXOpz05n98BzdHkt pmDD7EKMyCSjKLY9N0hArzj+p9qFTNE4qXaCA48yY4yBp4U72A+AAZ/2wsPe14Hq5jm9fR 9kpeezO590hqzS2fPno/p83WbIMQW8JjH55WOojrWa7uAhCre4t/llfphrujFw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765297982; a=rsa-sha256; cv=none; b=ROKKVa4sgWMcqAXjtCJDSGhq6QIzh4Q2URCif/F51tdwpt7lDy2ifkMh1hiRF1Ez7AJAAp DV8ECuLxc5jBHBhlnNLjqkNCabRUgO7BSQ0Hp4QS49kCjdbkNhVoZW4eFd7MIEQLPt3zjj NBKSyMGIT8Z4XkHHcPgltH86Eb1Wld2yhvKqQ3i2DirFBs+RdpeL2H2HWa9mG75YwTlG5N hMZ/kuEqKfpxpS71ZTzuK+RbAEJTuEwtUPc74YYT2MRTwGFDCnKxO4AJ3CfDTu6Wb/9axP 0kEY0VovXTEffQhMPIsKXsqpWoMGKzYuFSBEUEDpdvKJWi8nHG2OZp/O3zGt9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dQkt561Fbz15rP for ; Tue, 09 Dec 2025 16:33:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 9743 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 09 Dec 2025 16:33:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: ab4f4f4efaac - stable/15 - kgssapi: Remove broken MOD_UNLOAD code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: ab4f4f4efaac85bbf235e60f2ced4876a9e916f2 Auto-Submitted: auto-generated Date: Tue, 09 Dec 2025 16:33:01 +0000 Message-Id: <69384f3d.9743.64e3e17a@gitrepo.freebsd.org> The branch stable/15 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=ab4f4f4efaac85bbf235e60f2ced4876a9e916f2 commit ab4f4f4efaac85bbf235e60f2ced4876a9e916f2 Author: Ed Maste AuthorDate: 2025-11-27 16:44:08 +0000 Commit: Ed Maste CommitDate: 2025-12-09 16:32:09 +0000 kgssapi: Remove broken MOD_UNLOAD code The module panicked at unload with "recursing but non-recursive rw". There is a comment that "Unloading of the kgssapi module is not currently supported" and the MOD_UNLOAD case falls through to returning EOPNOTSUPP anyway. Just #if 0 the code in the unload path, leaving it as a hint in case someone implements unload support later on. PR: 291249 Reviewed by: rmacklem Fixes: ad704a34bc2c ("Use syscall_helper_register(9) rather than syscall_register().") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53949 (cherry picked from commit 6901376f59b870ddbb0d922e3455a388333cd460) --- sys/kgssapi/gss_impl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/kgssapi/gss_impl.c b/sys/kgssapi/gss_impl.c index c9cd4d880695..323b379e1619 100644 --- a/sys/kgssapi/gss_impl.c +++ b/sys/kgssapi/gss_impl.c @@ -88,6 +88,7 @@ kgss_load(void) return (0); } +#if 0 static void kgss_unload(void) { @@ -96,6 +97,7 @@ kgss_unload(void) clnt_destroy(KGSS_VNET(kgss_gssd_handle)); KGSS_CURVNET_RESTORE(); } +#endif int kgss_oid_equal(const gss_OID oid1, const gss_OID oid2) @@ -297,8 +299,10 @@ kgssapi_modevent(module_t mod, int type, void *data) error = kgss_load(); break; case MOD_UNLOAD: +#if 0 kgss_unload(); mtx_destroy(&kgss_gssd_lock); +#endif /* * Unloading of the kgssapi module is not currently supported. * If somebody wants this, we would need to keep track of