From owner-svn-src-all@FreeBSD.ORG  Wed Dec 22 19:18:10 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E6DC9106564A;
	Wed, 22 Dec 2010 19:18:10 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 92F078FC19;
	Wed, 22 Dec 2010 19:18:10 +0000 (UTC)
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id oBMJFCFp078430;
	Wed, 22 Dec 2010 12:15:12 -0700 (MST) (envelope-from imp@bsdimp.com)
Message-ID: <4D124E40.4080305@bsdimp.com>
Date: Wed, 22 Dec 2010 12:15:12 -0700
From: Warner Losh <imp@bsdimp.com>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6
MIME-Version: 1.0
To: "Bjoern A. Zeeb" <bz@FreeBSD.org>
References: <201012221459.oBMExM94017630@svn.freebsd.org>
	<20101222161723.T6126@maildrop.int.zabbadoz.net>
In-Reply-To: <20101222161723.T6126@maildrop.int.zabbadoz.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, Nathan Whitehorn <nwhitehorn@FreeBSD.org>
Subject: Re: svn commit: r216662 - head/share/mk
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Dec 2010 19:18:11 -0000

On 12/22/2010 09:18, Bjoern A. Zeeb wrote:
> On Wed, 22 Dec 2010, Nathan Whitehorn wrote:
>
>> Author: nwhitehorn
>> Date: Wed Dec 22 14:59:22 2010
>> New Revision: 216662
>> URL: http://svn.freebsd.org/changeset/base/216662
>>
>> Log:
>>  Enable build of FDT components by default. dtc is a required build tool
>>  for all FDT-enabled kernels, and having it off by default means that
>>  building these kernels fails by default. This fixes FDT-related build
>>  failures in make universe on ARM and PowerPC.
>
> Thanks a lot!  I wonder if it is arch specific conditional?  Is there
> any value in having it on non-FDT kernels/architectures?
>
> I am happily looking forward to a usable universe output again:-))
FDT enables building a tool that is sometimes used when building the kernel.

The problem is that it is a cross tool, and building things 
conditionally based on the architecture for cross tools is not well 
supported today.  The gross hack that attempted to do this was too hard 
to fix, so it is better to be always on.  The resulting bloat is tiny, 
it can be turned off if you want and it can be made conditional again 
once we have a better way to specify things like this conditionally.

Warner
>
>
>>  Reviewed by:    imp
>>
>> Modified:
>>  head/share/mk/bsd.own.mk
>>
>> Modified: head/share/mk/bsd.own.mk
>> ============================================================================== 
>>
>> --- head/share/mk/bsd.own.mk    Wed Dec 22 14:49:18 2010    (r216661)
>> +++ head/share/mk/bsd.own.mk    Wed Dec 22 14:59:22 2010    (r216662)
>> @@ -326,6 +326,7 @@ _clang_no=CLANG
>>     DICT \
>>     DYNAMICROOT \
>>     EXAMPLES \
>> +    FDT \
>>     FLOPPY \
>>     FORTH \
>>     FP_LIBC \
>> @@ -421,7 +422,6 @@ MK_${var}:=    yes
>>     BIND_XML \
>>     BSD_GREP \
>>     ${_clang_no} \
>> -    FDT \
>>     GPIO \
>>     HESIOD \
>>     IDEA
>>
>