From owner-dev-commits-src-main@freebsd.org Wed Jan 27 19:55:53 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AF3374E7F80; Wed, 27 Jan 2021 19:55:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DQvVK4cn5z3Gyp; Wed, 27 Jan 2021 19:55:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:61a6:928a:6f1b:828e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id DF90D28441; Wed, 27 Jan 2021 19:55:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: 5fe433a6e4d8 - main - netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support To: Kyle Evans , Lutz Donnerhacke Cc: Lutz Donnerhacke , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202101241941.10OJfCGA013081@gitrepo.freebsd.org> <20210124194640.GA6527@belenus.iks-jena.de> From: John Baldwin Message-ID: Date: Wed, 27 Jan 2021 11:55:51 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2021 19:55:53 -0000 On 1/24/21 11:51 AM, Kyle Evans wrote: > On Sun, Jan 24, 2021 at 1:47 PM Lutz Donnerhacke wrote: > We switched up the recommendations[0][1] to advocate for what you've > done here ~2 weeks ago -- so yes, this is good. :-) Note that "Submitted by" may still be needed when there are multiple authors who contribute to a patch. (And I do kind of think pulling it from the template was a bit hasty as it didn't take those cases into account.) I do think we want Author to reflect the primary author of the change though. -- John Baldwin