From owner-freebsd-bugs@FreeBSD.ORG  Mon Oct  6 02:40:18 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E427A16A4B3
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  6 Oct 2003 02:40:18 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4EF3143FE1
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  6 Oct 2003 02:40:18 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h969eHFY062409
	for <freebsd-bugs@freefall.freebsd.org>;
	Mon, 6 Oct 2003 02:40:17 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h969eHEp062408;
	Mon, 6 Oct 2003 02:40:17 -0700 (PDT)
	(envelope-from gnats)
Date: Mon, 6 Oct 2003 02:40:17 -0700 (PDT)
Message-Id: <200310060940.h969eHEp062408@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Peter Pentchev <roam@ringlet.net>
Subject: Re: bin/57641: [patch] missing option in mdmfs (mount_mfs)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Peter Pentchev <roam@ringlet.net>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Oct 2003 09:40:19 -0000

The following reply was made to PR bin/57641; it has been noted by GNATS.

From: Peter Pentchev <roam@ringlet.net>
To: Ruben de Groot <rdg@bzerk.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/57641: [patch] missing option in mdmfs (mount_mfs)
Date: Mon, 6 Oct 2003 12:38:25 +0300

 On Mon, Oct 06, 2003 at 10:46:58AM +0200, Ruben de Groot wrote:
 > 
 > >Number:         57641
 > >Category:       bin
 > >Synopsis:       [patch] missing option in mdmfs (mount_mfs)
 > >Originator:     Ruben de Groot
 > >Release:        FreeBSD 5.1-CURRENT i386
 [snip]
 > >Description:
 > 	
 > 	Currently, mdmfs will allways do a newfs before mounting a mfs.
 > 	When using filesystem image files (MD_VNODE), an option to skip
 > 	the newfs part, preserving the existing filesystem would be
 > 	desirable.
 [snip]
 > >Fix:
 > 
 > 	Add a -P option to mdmfs (and mount_mfs) that will skip the
 > 	do_newfs() part. Adding P to the fstab line above like this:
 [snip]
 > diff -u sbin/mdmfs.orig/mdmfs.8 sbin/mdmfs/mdmfs.8
 > --- sbin/mdmfs.orig/mdmfs.8	Wed Aug  6 04:41:52 2003
 > +++ sbin/mdmfs/mdmfs.8	Mon Oct  6 08:48:27 2003
 [snip]
 > @@ -195,6 +195,11 @@
 >  See
 >  .Xr mount 8
 >  for more information.
 > +.It Fl P
 > +Preserve existing filesystem. Do not run newfs. This only makes sense if
 > +.Fl F
 > +is specified
 > +.Pq Dv MD_VNODE .
 >  .It Fl p Ar permissions
 >  Set the file (directory) permissions of the mount point
 >  .Ar mount-point
 
 Just a minor mdoc comment on this part: generally we put new sentences
 on separate lines :)  Also, what do you think about this wording change:
 
 @@ -195,6 +195,12 @@
  See
  .Xr mount 8
  for more information.
 +.It Fl P
 +Preserve existing filesystem - do not run newfs.
 +This only makes sense if
 +.Fl F
 +is specified to create a vnode-backed disk
 +.Pq Dv MD_VNODE .
  .It Fl p Ar permissions
  Set the file (directory) permissions of the mount point
  .Ar mount-point
 
 G'luck,
 Peter
 
 -- 
 Peter Pentchev	roam@ringlet.net    roam@sbnd.net    roam@FreeBSD.org
 PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
 Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
 What would this sentence be like if it weren't self-referential?