Date: Sat, 16 Apr 2016 16:08:22 -0700 From: Conrad Meyer <cem@FreeBSD.org> To: Pedro Giffuni <pfg@freebsd.org> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: CFR: extend use of nitems() macro in the kernel. Message-ID: <CAG6CVpVvxQL3Gr9zJd75eSW0054q%2BS_0XrtkZaF=YPHb%2BNgJgA@mail.gmail.com> In-Reply-To: <57128385.6090307@FreeBSD.org> References: <57128385.6090307@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 16, 2016 at 11:25 AM, Pedro Giffuni <pfg@freebsd.org> wrote: > Hello; > > Using coccinelle, and some hand re-formatting, I generated a patch to > make use of the nitems() macro in sys, which is too big for > phabricator [1]. > > I was careful to exclude anything from the contrib directory or > any code that is shared with userland (as to not have to include > additional headers). > > The patch is big but pretty safe, I think. The changes are small but > still it touches many files[1]. > > I would like some feedback on the convenience of doing such replacement. > If it is a good idea we could do the same for roundup2() and, in fact, > I think DragonFly has already done this. Assuming this change is correct, I am all for it. Assuming roundup2()s can be cleaned up in an automated and correct way, I am all for that sort of mechanical change too. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpVvxQL3Gr9zJd75eSW0054q%2BS_0XrtkZaF=YPHb%2BNgJgA>