From owner-svn-src-all@FreeBSD.ORG  Fri Jul 18 20:16:52 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A0FAE43A;
 Fri, 18 Jul 2014 20:16:52 +0000 (UTC)
Received: from mail-qc0-x22d.google.com (mail-qc0-x22d.google.com
 [IPv6:2607:f8b0:400d:c01::22d])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3132A2AA6;
 Fri, 18 Jul 2014 20:16:52 +0000 (UTC)
Received: by mail-qc0-f173.google.com with SMTP id c9so3756983qcz.18
 for <multiple recipients>; Fri, 18 Jul 2014 13:16:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=2QS+sOagHm+26cww5+ZkoB6HErXRw8E75gj7B89VW3c=;
 b=bgjFzeaubD0Aj7F5mXxJpkg6hPnXLgRMHxYmxbylTza9o1hiBbogdzIZV+M75nn80H
 2jGOYaJvdsH3OGs9d2AjgWAhziQdnjyiFm8P+Ff7YleZ/5nxPMmDTXB7cwz14BUgpueq
 epjtvnQ9o6FPslYEmKI4wexMRe6iCNrwN9XTGney8CrLCgQrDJSXtKgOhz2B+PxIJB2D
 AfnNcCkzHsAQ2hGpOHA579M4Xwi4ESMfY/pxa0jg2ki5jeqxGyIqeDwsFIjFFSq67UVP
 3Umk4suC9a+sWLn4XfJeYnIC+EVsiVcqbCcYZysGjl+r9BwVfGKY2z6oQ+f4dkL4SErc
 YW1A==
MIME-Version: 1.0
X-Received: by 10.224.134.201 with SMTP id k9mr12084809qat.59.1405714611388;
 Fri, 18 Jul 2014 13:16:51 -0700 (PDT)
Sender: carpeddiem@gmail.com
Received: by 10.140.50.243 with HTTP; Fri, 18 Jul 2014 13:16:51 -0700 (PDT)
In-Reply-To: <201407111238.23391.jhb@freebsd.org>
References: <201407111616.s6BGGQFW060195@svn.freebsd.org>
 <201407111238.23391.jhb@freebsd.org>
Date: Fri, 18 Jul 2014 16:16:51 -0400
X-Google-Sender-Auth: JPSRsLTK3UPQ1B_3bXMgwgJiMlY
Message-ID: <CAPyFy2Cp_XofbGFUCBXegbKmFnzrZ6tO=48hHELeXOmMiBEi4Q@mail.gmail.com>
Subject: Re: Phabric IDs / URLs in commits
From: Ed Maste <emaste@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jul 2014 20:16:52 -0000

On 11 July 2014 12:38, John Baldwin <jhb@freebsd.org> wrote:
>>   CR:                 https://phabric.freebsd.org/D312
>>   Reviewed by:        jilles
>>   MFC after:  1 week
>
> Just picking my own commit here as a sample case.
>
> I think we should be annotating commits with phabricator code reviews in some
> way when a change has gone through that review.  It is very useful to get back
> to the review details from the commit log message in svnweb, etc.

FYI, Phabricator's canonical format for this is:
Differential Revision: http://phabric.freebsd.org/D312
It will then automatically associate the commit with the review and
close the review.

See for example LLVM review D4563:

Review: http://reviews.llvm.org/D4563
Commit: http://reviews.llvm.org/rL213304
(from LLVM's Phabricator repo browser; LLVM's viewvc seems to be down
at the moment.)

"Differential Revision" seems a bit unwieldy and "CR" does fit in
better with our other tags.  But we'll want to teach Phabricator to
parse our custom tag if we go that way.