From owner-freebsd-current@FreeBSD.ORG  Wed May  6 05:00:21 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 58BEB106566B
	for <current@freebsd.org>; Wed,  6 May 2009 05:00:21 +0000 (UTC)
	(envelope-from ben@wanderview.com)
Received: from mail.wanderview.com (mail.wanderview.com [66.92.166.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 03D698FC0C
	for <current@freebsd.org>; Wed,  6 May 2009 05:00:20 +0000 (UTC)
	(envelope-from ben@wanderview.com)
Received: from harkness.in.wanderview.com (harkness.in.wanderview.com
	[10.76.10.150]) (authenticated bits=0)
	by mail.wanderview.com (8.14.3/8.14.3) with ESMTP id n464xsxr002387
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)
	for <current@freebsd.org>; Wed, 6 May 2009 04:59:54 GMT
	(envelope-from ben@wanderview.com)
Message-Id: <EE174440-B065-40FE-8AAC-4FAFF4B782B4@wanderview.com>
From: Ben Kelly <ben@wanderview.com>
To: current@freebsd.org
In-Reply-To: <9A637B27-7C89-49BA-8385-A5B2D5D54BB3@wanderview.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v930.3)
Date: Wed, 6 May 2009 01:00:09 -0400
References: <9A637B27-7C89-49BA-8385-A5B2D5D54BB3@wanderview.com>
X-Mailer: Apple Mail (2.930.3)
X-Spam-Score: -1.44 () ALL_TRUSTED
X-Scanned-By: MIMEDefang 2.64 on 10.76.20.1
Cc: 
Subject: Re: [patch] corrupt memstat_kvm_malloc(3) output and dtrace
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 May 2009 05:00:21 -0000

On May 5, 2009, at 10:18 AM, Ben Kelly wrote:
> While debugging a problem recently with Alexander Leidinger we  
> noticed that crashinfo(8) was producing corrupt vmstat -m output.   
> After doing some digging it appears that memstat_kvm_malloc(3) might  
> have been broken by this commit:
>
>  http://svn.freebsd.org/viewvc/base?view=revision&revision=179222
>
> The problem is that memstat_kvm_malloc(3) assumes that  
> malloc_type_internal starts with an array of malloc_types_stats  
> structures.  This assumption is no longer true, though, as  
> mti_probes was inserted at the start of the structure.
>
> It appears that this (untested) patch might fix the problem:
>
>  http://www.wanderview.com/svn/public/misc/zfs/vmstat_kvm_malloc.diff
>
> I'm not very familiar with dtrace, though.  Does anyone know if this  
> would cause problems?

Just FYI, I was able to recompile and test this patch tonight.  It  
seems to have fixed vmstat -M $core -m output on my machine.

- Ben