From owner-freebsd-stable@FreeBSD.ORG Thu Apr 13 19:27:46 2006 Return-Path: X-Original-To: freebsd-stable@FreeBSD.org Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 63F6416A404 for ; Thu, 13 Apr 2006 19:27:46 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 877C943D67 for ; Thu, 13 Apr 2006 19:27:42 +0000 (GMT) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id k3DJRS1s025332; Thu, 13 Apr 2006 15:27:28 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: ian j hart , Sam Leffler Date: Thu, 13 Apr 2006 15:27:14 -0400 User-Agent: KMail/1.6.2 References: <200604131047.44821.pieter@degoeje.nl> <200604131203.09227.jkim@FreeBSD.org> <200604132005.55799.ianjhart@ntlworld.com> In-Reply-To: <200604132005.55799.ianjhart@ntlworld.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200604131527.16114.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.88/1396/Thu Apr 13 01:39:53 2006 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: Pieter de Goeje , freebsd-stable@FreeBSD.org Subject: Re: 6.1RC1: Unable to select Minimal distribution X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2006 19:27:46 -0000 On Thursday 13 April 2006 03:05 pm, ian j hart wrote: > On Thursday 13 April 2006 17:03, Jung-uk Kim wrote: > > On Thursday 13 April 2006 04:47 am, Pieter de Goeje wrote: > > > Hi, > > > > > > I installed FreeBSD 6.1RC1 in qemu. When sysinstall comes to > > > the "Choose Distributions" screen, I am unable to choose the > > > "Minimal" distribution. The [ ] stay blank. Also, selecting > > > All doesn't include it either. > > > > You may not see 'X' but it is selected. ;-) It seems to be an > > annoying bug in libdialog. Some releases were okay and some not. > > I'll look into it when I find some time. > > > > Jung-uk Kim > > ref: > http://docs.freebsd.org/cgi/mid.cgi?200603252247.00879.ianjhart > > Are you sure it's not one of the March 8th commits? Backing out > fixes this for me. Yes, you are correct. I was thinking that it was the same bug that I saw few years ago. :-( Good news is I found a fix: Index: menus.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/sysinstall/menus.c,v retrieving revision 1.417 diff -u -r1.417 menus.c --- menus.c 8 Mar 2006 18:02:32 -0000 1.417 +++ menus.c 13 Apr 2006 19:25:08 -0000 @@ -168,7 +168,7 @@ static int checkDistMinimum(dialogMenuItem *self) { - return Dists == (DIST_BASE); + return Dists == (DIST_BASE | DIST_KERNEL); } static int This function was returning false. ;-) Jung-uk Kim