From owner-svn-ports-head@freebsd.org Fri Mar 12 22:07:53 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 389A15AEB9E; Fri, 12 Mar 2021 22:07:53 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dy0LJ2JKbz3BtC; Fri, 12 Mar 2021 22:07:51 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 6627133E52; Fri, 12 Mar 2021 17:07:45 -0500 (EST) Received: from [192.168.1.5] (77.118.111.172.wireless.dyn.drei.com [77.118.111.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 9DB0C33E41; Fri, 12 Mar 2021 17:07:44 -0500 (EST) Date: Fri, 12 Mar 2021 23:07:28 +0100 (CET) From: Gerald Pfeifer To: Piotr Kubaj cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r568012 - head/net/tightvnc In-Reply-To: <202103101603.12AG371X067963@repo.freebsd.org> Message-ID: <13e0fa6a-7ea4-d321-c75e-474eeb415ee9@pfeifer.com> References: <202103101603.12AG371X067963@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4Dy0LJ2JKbz3BtC X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-3.04 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[gerald]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.68.5.143:from]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_ZRD(0.00)[209.68.5.143:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.74)[-0.735]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[svn-ports-all,svn-ports-head] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2021 22:07:53 -0000 On Wed, 10 Mar 2021, Piotr Kubaj wrote: > Author: pkubaj Date: Wed Mar 10 16:03:06 2021 New Revision: 568012 URL: > https://svnweb.freebsd.org/changeset/ports/568012 > > Log: > net/tightvnc: fix build on powerpc64* and probably also on aarch64 and riscv64 > > Clang can't build this, use GCC: > In file included from ./cfbmskbits.h:39: > ../hw/xfree86/common/compiler.h:437:8: error: invalid output constraint '=a' in asm > "=a" (ret) : > +.if ${ARCH} == aarch64 || ${ARCH:Mpowerpc64*} || ${ARCH} == riscv64 > +USE_GCC= any > +.endif Do you intentionally focus on USE_GCC=any? On riscv64 this is always equivalent to USE_GCC=yes, and even on powerpc - do we want to use the the age old GCC 4.2 in base *and*, more importantly, use different compilers on 11.x and 13.x? USE_GCC=yes avoids all of this and provides more consistency and fewer test escapes. Gerald