Date: Mon, 10 Dec 2012 09:40:00 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Rene Ladan <rene@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308525 - head/www/chromium Message-ID: <20121210094000.GI34139@FreeBSD.org> In-Reply-To: <201212091144.qB9Bi8w4042233@svn.freebsd.org> References: <201212091144.qB9Bi8w4042233@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 09, 2012 at 11:44:08AM +0000, Rene Ladan wrote: > New Revision: 308525 > URL: http://svnweb.freebsd.org/changeset/ports/308525 > > Log: > Use empty() instead of negation to check for non-set options. Why? Technically they are equivalent, however: - !-form is given as an example in PH (Example 5-12); - In the same PH page, in the last note, empty() is only suggested as alternative syntax when tradition check cannot be used for some reason; - empty()-form is more error prone: it's relatively easy to make mistakes like empty(${FOO}) vs. correct emtpy(FOO) which go unnoticed as make(1) does not issue any warning; - Let's not increase diversity in syntax; most ports use !-form. That said, please reconsider. Thanks, ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121210094000.GI34139>