From owner-freebsd-ports-bugs@FreeBSD.ORG Wed May 1 06:40:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 6F370E06 for ; Wed, 1 May 2013 06:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 50DD01DC2 for ; Wed, 1 May 2013 06:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r416e1Lh048806 for ; Wed, 1 May 2013 06:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r416e1K5048805; Wed, 1 May 2013 06:40:01 GMT (envelope-from gnats) Resent-Date: Wed, 1 May 2013 06:40:01 GMT Resent-Message-Id: <201305010640.r416e1K5048805@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matthieu Volat Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B35EBDF7 for ; Wed, 1 May 2013 06:38:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [69.147.83.34]) by mx1.freebsd.org (Postfix) with ESMTP id A5CA91DB8 for ; Wed, 1 May 2013 06:38:06 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r416c33t048651 for ; Wed, 1 May 2013 06:38:03 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r416c3XU048650; Wed, 1 May 2013 06:38:03 GMT (envelope-from nobody) Message-Id: <201305010638.r416c3XU048650@red.freebsd.org> Date: Wed, 1 May 2013 06:38:03 GMT From: Matthieu Volat To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/178274: [patch] audio/musicpd : add MDNSRESDPONDER port option X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2013 06:40:01 -0000 >Number: 178274 >Category: ports >Synopsis: [patch] audio/musicpd : add MDNSRESDPONDER port option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed May 01 06:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Matthieu Volat >Release: 9.1-RELEASE >Organization: >Environment: FreeBSD freedom.alkumuna.eu 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec 4 09:23:10 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: audio/musicpd port is only allowing to enable Avahi support while mDNSResponder support is possible in mpd, and only one option away. Could it be added? I've attached a patch for the port Makefile. >How-To-Repeat: cd /usr/ports/audio/musicpd && make config -> only avahi option >Fix: apply/adapt provided patch to provide a radio choice for zeroconf support and allows to use mDNSResponder as choice of implementation. Patch attached with submission follows: diff -ru Makefile.orig Makefile --- Makefile.orig 2013-04-30 22:48:02.000000000 +0200 +++ Makefile 2013-05-01 08:27:47.000000000 +0200 @@ -34,9 +34,11 @@ SUB_FILES= pkg-message -OPTIONS_DEFINE= ID3TAG IPV6 AVAHI FLAC VORBIS WAV FFMPEG TREMOR AAC \ +OPTIONS_DEFINE= ID3TAG IPV6 FLAC VORBIS WAV FFMPEG TREMOR AAC \ MUSEPACK MIKMOD MODPLUG ARCHIVE MMS LASTFM AO PULSEAUDIO \ JACK SHOUTCAST SNDFILE LAME HTTPD SAMPLERATE CUE +OPTIONS_RADIO= ZEROCONF +OPTIONS_RADIO_ZEROCONF= AVAHI MDNSRESPONDER OPTIONS_DEFAULT=ID3TAG IPV6 FLAC VORBIS WAV FFMPEG SNDFILE LAME_DESC= Support for MP3 Icecast Streams @@ -179,6 +181,13 @@ CONFIGURE_ARGS+=--with-zeroconf=no .endif +.if ${PORT_OPTIONS:MMDNSRESPONDER} +CONFIGURE_ARGS+=--with-zeroconf=bonjour +LIB_DEPENDS+= dns_sd:${PORTSDIR}/net/mDNSResponder +.else +CONFIGURE_ARGS+=--with-zeroconf=no +.endif + .if ${PORT_OPTIONS:MAO} CONFIGURE_ARGS+=--enable-ao LIB_DEPENDS+= ao.4:${PORTSDIR}/audio/libao >Release-Note: >Audit-Trail: >Unformatted: