From owner-cvs-ports@FreeBSD.ORG Wed Aug 11 11:14:02 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7DB7416A4CE; Wed, 11 Aug 2004 11:14:02 +0000 (GMT) Received: from yello.shallow.net (yello.shallow.net [203.18.243.120]) by mx1.FreeBSD.org (Postfix) with ESMTP id B693D43D67; Wed, 11 Aug 2004 11:14:01 +0000 (GMT) (envelope-from joshua@shallow.net) Received: by yello.shallow.net (Postfix, from userid 1001) id 01A5D2A65; Wed, 11 Aug 2004 21:13:57 +1000 (EST) Date: Wed, 11 Aug 2004 21:13:57 +1000 From: Joshua Goodall To: "Vanilla I. Shu" , blaz@si.FreeBSD.org Message-ID: <20040811111357.GA20555@roughtrade.net> References: <200407181005.i6IA5oV4084200@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200407181005.i6IA5oV4084200@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-ports@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/amavisd-new Makefile distinfo pkg-plist ports/security/amavisd-new/files INSTALL.tmpl MESSAGE.tmpl amavisd.sh.tmpl patch-amavisd patch-amavisd-sample.conf patch-amavisd.conf perlwarning.tmpl X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Aug 2004 11:14:02 -0000 Hi I found three problems with the latest amavisd-new port: On Sun, Jul 18, 2004 at 10:05:50AM +0000, Vanilla I. Shu wrote: > - remove taint checks when running perl 5.00503 Was this actually tested on 5.00503, though? This version of amavisd-new doesn't even start up on a stock 4.10-RELEASE box I have here: root@server:~# /usr/local/etc/rc.d/amavisd.sh start Starting amavisd. Can't locate warnings.pm in @INC (@INC contains: /usr/local/lib/perl5/site_perl/5.005/i386-freebsd /usr/local/lib/perl5/site_perl/5.005 . /usr/libdata/perl/5.00503/mach /usr/libdata/perl/5.00503) at /usr/local/sbin/amavisd line 1549. BEGIN failed--compilation aborted at /usr/local/sbin/amavisd line 1549. because there is no 'use warnings / no warnings' option in 5.00503. The following message isn't sufficient: ------------------------------------------------------------------- WARNING: You appear to be running perl version 5.00503. amavisd-new has been tested and is guaranteed to run only with perl 5.8.2 and above. There are numerous problems with amavisd-new when running under previous perl versions, including perl crashes, taint bugs and others. You are strongly advised to upgrade your perl by using the /usr/ports/lang/perl5.8 port. ------------------------------------------------------------------- If you require 5.8.2, you should depend on it explicitly. I didn't even see this warning first time around; it scrolled away. There also appears to be a missed substitution; root@server:/usr/ports/security/amavisd-new# grep %%PREFIX%% /usr/local/sbin/amavisd my($config_file) = '%%PREFIX%%/etc/amavisd.conf'; # default location of config file Although possibly this is because you've concatenated amavisd to itself in the port Makefile thanks to the >> in line 109 vs line 103: root@server:/usr/ports/security/amavisd-new# ls -l work/amavisd-new-20040701/amavisd work/amavisd -rw-r--r-- 1 root wheel 967063 Aug 11 20:59 work/amavisd -rwxr-xr-x 1 root wheel 483533 Aug 11 20:59 work/amavisd-new-20040701/amavisd Finally, the package needs to mkdir+chmod+chown /var/amavis/tmp: Aug 11 20:57:47 server amavis[88769]: TROUBLE in pre_loop_hook: TEMPBASE directory is not writable: /var/amavis/tmp at /usr/local/sbin/amavisd line 5543. Please fix :) Thanks! Joshua.