From owner-svn-src-all@freebsd.org  Sun May 19 15:53:33 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DEC6815B1362;
 Sun, 19 May 2019 15:53:33 +0000 (UTC)
 (envelope-from ota@j.email.ne.jp)
Received: from mail03.asahi-net.or.jp (mail03.asahi-net.or.jp [202.224.55.15])
 by mx1.freebsd.org (Postfix) with ESMTP id 56D306A1C5;
 Sun, 19 May 2019 15:53:32 +0000 (UTC)
 (envelope-from ota@j.email.ne.jp)
Received: from vmware.advok.com (pool-72-76-119-135.nwrknj.fios.verizon.net
 [72.76.119.135]) (Authenticated sender: NR2Y-OOT)
 by mail03.asahi-net.or.jp (Postfix) with ESMTPSA id 94BDF42EB9;
 Mon, 20 May 2019 00:53:19 +0900 (JST)
Date: Sun, 19 May 2019 11:52:28 -0400
From: Yoshihiro Ota <ota@j.email.ne.jp>
To: Konstantin Belousov <kib@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r347968 - head/sys/kern
Message-Id: <20190519115228.49fdc5c833c2abe06f894dc2@j.email.ne.jp>
In-Reply-To: <201905190918.x4J9IAs1036579@repo.freebsd.org>
References: <201905190918.x4J9IAs1036579@repo.freebsd.org>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; i386-portbld-freebsd12.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 56D306A1C5
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.96 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.96)[-0.961,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 May 2019 15:53:34 -0000

Hi,

Does this change fix 'mount -u -rw /path' to remount read-only device with write mode?
I moticed an issue a couple of days ago but didn't have time to conform nor report.

Thanks,
Hiro

On Sun, 19 May 2019 09:18:10 +0000 (UTC)
Konstantin Belousov <kib@FreeBSD.org> wrote:

> Author: kib
> Date: Sun May 19 09:18:09 2019
> New Revision: 347968
> URL: https://svnweb.freebsd.org/changeset/base/347968
> 
> Log:
>   Fix rw->ro remount when there is a text vnode mapping.
>   
>   Reported and tested by:	hrs
>   Sponsored by:	The FreeBSD Foundation
>   MFC after:	16 days
> 
> Modified:
>   head/sys/kern/vfs_subr.c
> 
> Modified: head/sys/kern/vfs_subr.c
> ==============================================================================
> --- head/sys/kern/vfs_subr.c	Sun May 19 06:01:11 2019	(r347967)
> +++ head/sys/kern/vfs_subr.c	Sun May 19 09:18:09 2019	(r347968)
> @@ -3146,7 +3146,7 @@ loop:
>  
>  			if ((vp->v_type == VNON ||
>  			    (error == 0 && vattr.va_nlink > 0)) &&
> -			    (vp->v_writecount == 0 || vp->v_type != VREG)) {
> +			    (vp->v_writecount <= 0 || vp->v_type != VREG)) {
>  				VOP_UNLOCK(vp, 0);
>  				vdropl(vp);
>  				continue;
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"