From owner-cvs-all Thu Dec 2 19:12:35 1999 Delivered-To: cvs-all@freebsd.org Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by hub.freebsd.org (Postfix) with ESMTP id C5D8C14FF7; Thu, 2 Dec 1999 19:12:26 -0800 (PST) (envelope-from gallatin@cs.duke.edu) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.1/8.9.1) with ESMTP id WAA18430; Thu, 2 Dec 1999 22:11:53 -0500 (EST) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.9.3/8.9.1) id WAA70785; Thu, 2 Dec 1999 22:11:23 -0500 (EST) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Thu, 2 Dec 1999 22:11:23 -0500 (EST) To: mjacob@feral.com Cc: mckusick@mckusick.com, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mount.h src/sys/kern vfs_bio.c src/sys/miscfs/specfs spec_vnops.c In-Reply-To: References: <14407.12580.411786.947071@grasshopper.cs.duke.edu> X-Mailer: VM 6.43 under 20.4 "Emerald" XEmacs Lucid Message-ID: <14407.13249.163881.210052@grasshopper.cs.duke.edu> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Matthew Jacob writes: > > I did indeed see that Jordan committed the change. I would personally have > preferred to see explicit size values instead. Why did you choose to > truncate the name storage rather than change the 'longs' to 'int32_t's? Primarily because it seemed to be in the spirit of Kirk's original patch to carve space out of the string. Also, it seemed rather expediant & I wanted to get it committed quickly. I wanted to prevent people from getting nailed by a combo of the bdev elimination & the mount incompatability this problem introduced. From you message on -current, it looks like you were a victim of just this. Drew ------------------------------------------------------------------------------ Andrew Gallatin, Sr Systems Programmer http://www.cs.duke.edu/~gallatin Duke University Email: gallatin@cs.duke.edu Department of Computer Science Phone: (919) 660-6590 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message