Date: Tue, 9 Feb 2021 15:37:46 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Mateusz Guzik <mjg@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: af366d353b84 - main - amd64: implement strlen in assembly Message-ID: <83E33E2F-F7FE-4385-8F99-0A7235F87C63@freebsd.org> In-Reply-To: <202102081915.118JFXkJ067892@gitrepo.freebsd.org> References: <202102081915.118JFXkJ067892@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Here's your review after reading through it for <5 minutes today: On 8 Feb 2021, at 19:15, Mateusz Guzik <mjg@FreeBSD.org> wrote: > + leaq (%r11,%r8),%rcx > + notq %r11 > + andq %r11,%rcx > + andq %r9,%rcx > ... > + leaq (%r11,%r8),%rcx > + notq %r11 > + andq %rcx,%r11 These look the wrong way round (but you got it the right way round above). > + andq %r9,%rcx Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?83E33E2F-F7FE-4385-8F99-0A7235F87C63>