From owner-freebsd-arch@FreeBSD.ORG  Sat Apr 11 16:55:53 2009
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 04544106564A
	for <arch@FreeBSD.org>; Sat, 11 Apr 2009 16:55:53 +0000 (UTC)
	(envelope-from jasone@FreeBSD.org)
Received: from canonware.com (canonware.com [64.183.146.166])
	by mx1.freebsd.org (Postfix) with ESMTP id DC8338FC0A
	for <arch@FreeBSD.org>; Sat, 11 Apr 2009 16:55:52 +0000 (UTC)
	(envelope-from jasone@FreeBSD.org)
Received: from [192.168.168.201] (unknown [192.168.168.201])
	by canonware.com (Postfix) with ESMTPA id 2913050819;
	Sat, 11 Apr 2009 09:39:48 -0700 (PDT)
Message-ID: <49E0C7D3.1010005@FreeBSD.org>
Date: Sat, 11 Apr 2009 09:39:47 -0700
From: Jason Evans <jasone@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.21 (X11/20090318)
MIME-Version: 1.0
To: Robert Watson <rwatson@FreeBSD.org>
References: <alpine.BSF.2.00.0904111700241.19879@fledge.watson.org>
In-Reply-To: <alpine.BSF.2.00.0904111700241.19879@fledge.watson.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: arch@FreeBSD.org
Subject: Re: Simple #define for cache line size
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Apr 2009 16:55:53 -0000

Robert Watson wrote:
> Index: arm/include/param.h
> ===================================================================
> --- arm/include/param.h    (revision 190941)
> +++ arm/include/param.h    (working copy)
> @@ -81,6 +81,10 @@
>  #define    ALIGNBYTES    _ALIGNBYTES
>  #define    ALIGN(p)    _ALIGN(p)
> 
> +#ifndef CACHE_LINE_SIZE
> +#define    CACHE_LINE_SIZE    64
> +#endif
> +
>  #define    PAGE_SHIFT    12
>  #define    PAGE_SIZE    (1 << PAGE_SHIFT)    /* Page size */
>  #define    PAGE_MASK    (PAGE_SIZE - 1)
> Index: powerpc/include/param.h

It would be helpful to instead do:

#ifndef CACHE_LINE_SHIFT
#define	CACHE_LINE_SHIFT 6
#endif
#define	CACHE_LINE_SIZE (1 << CACHE_LINE_SHIFT)

In particular, src/lib/libc/stdlib/malloc.c would benefit.

Thanks,
Jason