From owner-freebsd-current@FreeBSD.ORG Sun Apr 6 12:35:54 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78E5237B401 for ; Sun, 6 Apr 2003 12:35:54 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 91ADB43FB1 for ; Sun, 6 Apr 2003 12:35:53 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h36JZpLd029408; Sun, 6 Apr 2003 21:35:51 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: des@ofug.org (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 06 Apr 2003 21:16:55 +0200." Date: Sun, 06 Apr 2003 21:35:51 +0200 Message-ID: <29407.1049657751@critter.freebsd.dk> cc: current@freebsd.org Subject: Re: weird fxp / timecounter interaction in top-of-tree X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Apr 2003 19:35:54 -0000 In message , Dag-Erling =?iso-8859-1?q?Sm=F8 rgrav?= writes: >"Poul-Henning Kamp" writes: >> Defining "best" is at best hard, so I have resorted to the simple >> technique we use now: Don't call tc_init on a timecounter unless >> you want to use it. > >Huh? I added a Debugger() call to tc_init(), and can assure you that >it gets called for every timecounter in the system (in my case i8254, >PIIX, TSC and ACPI, not necessarily in that order). But they they happen, by no coincidence, to be called in exactly the right order to result in the best safe choice in current circumstances :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.