From owner-svn-src-head@freebsd.org  Thu Aug  9 04:16:42 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CED201053738;
 Thu,  9 Aug 2018 04:16:42 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 829C47E690;
 Thu,  9 Aug 2018 04:16:42 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com
 [209.85.208.174])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G3" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 217402256B;
 Thu,  9 Aug 2018 04:16:42 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-lj1-f174.google.com with SMTP id p6-v6so3390608ljc.5;
 Wed, 08 Aug 2018 21:16:42 -0700 (PDT)
X-Gm-Message-State: AOUpUlFHiUQEPevp8wnog/kq0w847d+Jxa6OE7hUXJZHbRFWy1Vea8As
 lZgcOEmismaGe1VrEyblTV3NNDS+qmAtMjSHsYo=
X-Google-Smtp-Source: AA+uWPzZKDTFPwjFgkZcEa4nOzkYf3b/DlPEyVdqA0HzO2V+klmxkqaTwu5lvBMf+qWtb3lZI9VXZnU7mtnLeY9hchA=
X-Received: by 2002:a2e:4055:: with SMTP id n82-v6mr231378lja.99.1533788200702; 
 Wed, 08 Aug 2018 21:16:40 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP;
 Wed, 8 Aug 2018 21:16:20 -0700 (PDT)
In-Reply-To: <CANCZdfrW+a=fX21dzuHEERwC38je7nkTiJ0nssZ75JYU-ni8VQ@mail.gmail.com>
References: <201808082137.w78Lb2B5031967@repo.freebsd.org>
 <CAF6rxgm3x=fQB2OqrE=zoi89qGR0KTuST_AiEzf+aGtsGY_DyA@mail.gmail.com>
 <CACNAnaGjdBa5mmiiOe8O+omsBSA5YOCUnLDEL-jCcaSRQZKsTQ@mail.gmail.com>
 <CANCZdfrW+a=fX21dzuHEERwC38je7nkTiJ0nssZ75JYU-ni8VQ@mail.gmail.com>
From: Kyle Evans <kevans@freebsd.org>
Date: Wed, 8 Aug 2018 23:16:20 -0500
X-Gmail-Original-Message-ID: <CACNAnaEufMXasfAVXQXG+aqWwyQi=TM6P81A2tEG9KEA90jsZg@mail.gmail.com>
Message-ID: <CACNAnaEufMXasfAVXQXG+aqWwyQi=TM6P81A2tEG9KEA90jsZg@mail.gmail.com>
Subject: Re: svn commit: r337505 - head/bin/dd
To: Warner Losh <imp@bsdimp.com>
Cc: Eitan Adler <lists@eitanadler.com>,
 src-committers <src-committers@freebsd.org>, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2018 04:16:43 -0000

On Wed, Aug 8, 2018 at 8:15 PM, Warner Losh <imp@bsdimp.com> wrote:
>
>
> On Wed, Aug 8, 2018 at 7:01 PM, Kyle Evans <kevans@freebsd.org> wrote:
>>
>> On Wed, Aug 8, 2018 at 7:58 PM, Eitan Adler <lists@eitanadler.com> wrote:
>> > On Wed, 8 Aug 2018 at 14:37, Kyle Evans <kevans@freebsd.org> wrote:
>> >> +/* ARGSUSED */
>> >
>> > We've been slowly delintifying system utilities. Why do we still keep
>> > these comments?
>> >
>>
>> This is consistent with the style of the file, so I didn't object.
>> I'd rather do another pass later to de-lintify the whole thing rather
>> than nitpick at this patch for some otherwise harmless and matching
>> comments. =)
>
>
> It appears to be from NetBSD upstream, so removing it would be pointless
> churn that makes things harder to merge.
>

Poking at NetBSD now that I have time, it doesn't look like they
actually have this feature. They have progress=<n> to output a dog
every n blocks, but apparently not one that actually does a
single-line summary every second like this and GNU dd (with the same
status=progress flag).