From owner-cvs-all@FreeBSD.ORG  Tue Mar 29 20:28:36 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6687216A4CE; Tue, 29 Mar 2005 20:28:36 +0000 (GMT)
Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 06F0243D39; Tue, 29 Mar 2005 20:28:36 +0000 (GMT)
	(envelope-from obrien@NUXI.com)
Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1])
	by dragon.NUXI.org (8.13.3/8.13.3) with ESMTP id j2TKSZnZ035558;
	Tue, 29 Mar 2005 12:28:35 -0800 (PST)
	(envelope-from obrien@dragon.NUXI.org)
Received: (from obrien@localhost)
	by dragon.NUXI.org (8.13.3/8.13.1/Submit) id j2TKSZTf035557;
	Tue, 29 Mar 2005 12:28:35 -0800 (PST)
	(envelope-from obrien)
Date: Tue, 29 Mar 2005 12:28:34 -0800
From: "David O'Brien" <obrien@FreeBSD.org>
To: Eric Anholt <anholt@FreeBSD.org>
Message-ID: <20050329202834.GA35518@dragon.NUXI.org>
References: <200503292017.j2TKHlaa062618@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200503292017.j2TKHlaa062618@repoman.freebsd.org>
X-Operating-System: FreeBSD 6.0-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
User-Agent: Mutt/1.5.9i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/memcontrol memcontrol.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@FreeBSD.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2005 20:28:36 -0000

On Tue, Mar 29, 2005 at 08:17:47PM +0000, Eric Anholt wrote:
> anholt      2005-03-29 20:17:47 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.sbin/memcontrol  memcontrol.c 
>   Log:
>   Correct formatting of pointers in the listing by using "0x%" PRIx64 instead of
>   "%" PRIu64 "x".

I'd like to tweak this even more:

+	printf("%#.*" PRIx64 "/%" PRIu64 " %.8s ",
+	    sizeof mrd[i].mr_base, mrd[i].mr_base, mrd[i].mr_len,
+	    mrd[i].mr_owner[0] ? mrd[i].mr_owner : "-");

This gives output like:

0x00010000/65536 BIOS write-back fixed-base fixed-length set-by-firmware active 
0x00080000/16384 BIOS write-back fixed-base fixed-length set-by-firmware active 

I think lengths in decimal are more clear, and having addresses lined up
also makes it easier to read the output.