From owner-svn-src-head@freebsd.org  Sun Jul 24 10:15:10 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46D10B9BDF9;
 Sun, 24 Jul 2016 10:15:10 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 31C3617E9;
 Sun, 24 Jul 2016 10:15:09 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u6OAF8C5036214
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 24 Jul 2016 03:15:08 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id u6OAF8CS036213;
 Sun, 24 Jul 2016 03:15:08 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sun, 24 Jul 2016 03:15:08 -0700
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r303263 - in head/sys: compat/svr4 net
Message-ID: <20160724101508.GJ1076@FreeBSD.org>
References: <201607241010.u6OAA9IJ012434@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201607241010.u6OAA9IJ012434@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jul 2016 10:15:10 -0000

On Sun, Jul 24, 2016 at 10:10:09AM +0000, Gleb Smirnoff wrote:
T> Author: glebius
T> Date: Sun Jul 24 10:10:09 2016
T> New Revision: 303263
T> URL: https://svnweb.freebsd.org/changeset/base/303263
T> 
T> Log:
T>   Partially revert r257696/r257713, which have an issue with writing to user
T>   controlled address. Restore the old code that emulated OSIOCGIFCONF in if.c.
T>   
T>   Noticed by:	C Turt

I believe no one on the planet uses compat_svr4, but better fix it for
11.0-RELEASE, since too late to remove it.

Note that SVR4_SIOCGIFCONF actually won't work for FreeBSD 10.x, if
you load in compat_svr4.ko, since it depends on COMPAT_43 functionality
compiled in kernel, which isn't case for i386 GENERIC.

Of course the change wasn't tested, since I don't know how to produce
or where to take an SVR4 binary that does something useful with
SVR4_SIOCGIFCONF.

-- 
Totus tuus, Glebius.