From owner-cvs-src@FreeBSD.ORG  Sat Dec  4 07:42:25 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id DB42616A4CE; Sat,  4 Dec 2004 07:42:25 +0000 (GMT)
Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 778A243D41; Sat,  4 Dec 2004 07:42:25 +0000 (GMT)
	(envelope-from jroberson@chesapeake.net)
Received: from mail.chesapeake.net (localhost [127.0.0.1])
	by mail.chesapeake.net (8.12.10/8.12.10) with ESMTP id iB47gO0N099912;
	Sat, 4 Dec 2004 02:42:24 -0500 (EST)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)iB47gOPV099905;
	Sat, 4 Dec 2004 02:42:24 -0500 (EST)
	(envelope-from jroberson@chesapeake.net)
X-Authentication-Warning: mail.chesapeake.net: jroberson owned process doing
	-bs
Date: Sat, 4 Dec 2004 02:42:24 -0500 (EST)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Nate Lawson <nate@root.org>
In-Reply-To: <41B091E8.2060807@root.org>
Message-ID: <20041204024212.K18185@mail.chesapeake.net>
References: <20041203120940.5573116A515@hub.freebsd.org>
	<41B091E8.2060807@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Poul-Henning Kamp <phk@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern vfs_subr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Dec 2004 07:42:26 -0000

On Fri, 3 Dec 2004, Nate Lawson wrote:

> Poul-Henning Kamp wrote:
> > phk         2004-12-03 12:09:34 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/kern             vfs_subr.c
> >   Log:
> >   Improve vprint() a little bit:  break long lines, reduce indent and tell
> >   if the VI_LOCK() is held.
> >
> >   Revision  Changes    Path
> >   1.555     +7 -4      src/sys/kern/vfs_subr.c
> >
> >
> > --- src/sys/kern/vfs_subr.c:1.554	Wed Dec  1 23:16:36 2004
> > +++ src/sys/kern/vfs_subr.c	Fri Dec  3 12:09:34 2004
> > @@ -2651,9 +2651,9 @@
> >  		printf("%s: %p: ", label, (void *)vp);
> >  	else
> >  		printf("%p: ", (void *)vp);
> > -	printf("tag %s, type %s, usecount %d, writecount %d, refcount %d,",
> > -	    vp->v_tag, typename[vp->v_type], vp->v_usecount,
> > -	    vp->v_writecount, vp->v_holdcnt);
> > +	printf("tag %s, type %s\n    ", vp->v_tag, typename[vp->v_type]);
> > +	printf("usecount %d, writecount %d, refcount %d mountedhere %p\n",
> > +	    vp->v_usecount, vp->v_writecount, vp->v_holdcnt, vp->v_mountedhere);
> >  	buf[0] = '\0';
> >  	if (vp->v_vflag & VV_ROOT)
> >  		strcat(buf, "|VV_ROOT");
> > @@ -2672,7 +2672,10 @@
> >  	if (vp->v_vflag & VV_OBJBUF)
> >  		strcat(buf, "|VV_OBJBUF");
> >  	if (buf[0] != '\0')
> > -		printf(" flags (%s),", &buf[1]);
> > +		printf("    flags (%s)", &buf[1]);
> > +	if (mtx_owned(VI_MTX(vp)))
> > +		printf(" VI_LOCKed");
> > +	printf("\n    ");
> >  	lockmgr_printinfo(vp->v_vnlock);
> >  	printf("\n");
> >  	if (vp->v_data != NULL)
>
> I think that breaking vprint() into multiple lines is not a good idea.
> Bruce pointed this out to me when I was doing the v_tag changes a while ago.

What's the reason?

>
> -Nate
>