From nobody Fri Feb 14 15:10:56 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yvb8x2mr9z5nDwR; Fri, 14 Feb 2025 15:10:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yvb8x1Bb0z4K5W; Fri, 14 Feb 2025 15:10:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739545857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z9DRlNbOjKWql2TTaM06po1PHyImIysqCujJrgUQjfo=; b=tZPixJBb20DPrVBc4gbLtvzcM1q/qQcxiqXZp49tjLeVEFXqxV/TDWkxV6fIYqzfLPws6c KNoSf9ZSbnJSxDX+VVFI/lI4hjQqZQLFkghN0u9MJk9J6ZzrPog9b7QUJB8FSkGZcQ20xh nKvhkk3b5WUSIas2l0VWA6ahuLrfQUK2U6v8Ea7MV3UALUCx/Etu/4sSHQUavVffDr4HJ2 knk9h0pzry/1z9OQwsV2JOLjLfvD6C9+EqjzyckaHlUlxpVLXnWNeew5ve42x22Jr4ajoK vQdLng4w8zfzZUJDB2a6XDj+7yvDOWsU1A56RcLyIcxQPr0sIO043bfEou7lug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739545857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z9DRlNbOjKWql2TTaM06po1PHyImIysqCujJrgUQjfo=; b=yTH+I9zhVaydFGnsQOcp/oHJfJo9MVjWe/SfA9jKNk7RjlgH9Z71IyoTEAoLgwuc4+SQ83 PDPU68Dfd0WVYaxPaL6s0YmlFYw7MTWVtGV48G+e81hFmbbhLlAH5BRMkUrObZjOLfMOSg MGFZh0IY6sP9h6KIzf25nNrY5vSMkKcHZLv2Z30ujS6SYm3/6Bg4DWYQ5lVlZfbIvzHFP+ 1KoBjxow+pIX9qvxlbKsU/iRRlbla9iZDbYXrvwJg9XLUIrFsdtMbfxSnIOuuCZuJBlcWU AqspERw9VtE0j/XE2ZiV4bL/ZUTPVetAXqQWiMj4Fv/qNeIiDZjm7vvk1nEBxQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739545857; a=rsa-sha256; cv=none; b=l0av8I9iCtZD8pO6DNIDTOgsYK+LbA4Fg2qhujZsvjUH2T0ciA/DY3arruCTJMX4aULt4X 65W1g+lbESXYXeBGcfd8wKkm7BrvLTkB3aFjEXIIx1X0III01P/2uqQnFC7kO2EzmoTcwN 1HYQdNPJtOzKLBcOJQbopNcdRktVdsVne6T0zeEptwA2XgIzmckRdk9OmnTb2o6F2CQ+gh SgDVKrE/OV4Mglvs2dJpHW0RNLtRRADsyilLdqT619Uu9i59WNgHRLQM8QDitc56JtiUn4 tVILT1Nra1sPyBalKaBZJZWzYskUhRWtbcb3dsfulRKroPpPOPg5Yg8n/sL6Og== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yvb8x0VNlzcYV; Fri, 14 Feb 2025 15:10:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51EFAud0063291; Fri, 14 Feb 2025 15:10:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51EFAua5063288; Fri, 14 Feb 2025 15:10:56 GMT (envelope-from git) Date: Fri, 14 Feb 2025 15:10:56 GMT Message-Id: <202502141510.51EFAua5063288@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 909e2d7b691f - main - gve: Disallow MTUs within a problematic range List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 909e2d7b691f7418a78b1289a51d3b6c46860a9b Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=909e2d7b691f7418a78b1289a51d3b6c46860a9b commit 909e2d7b691f7418a78b1289a51d3b6c46860a9b Author: Jasper Tran O'Leary AuthorDate: 2025-02-14 14:57:06 +0000 Commit: Mark Johnston CommitDate: 2025-02-14 14:57:06 +0000 gve: Disallow MTUs within a problematic range If hardware LRO is enabled with GVE, then setting the driver's MTU to a range of values around 8000 will cause dropped packets and drastically degraded performance. While this issue is being investigated, we need to prohibit the driver's MTU being set to a value within this range. Signed-off-by: Jasper Tran O'Leary Reviewed by: delphij, markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D48971 --- sys/dev/gve/gve_main.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sys/dev/gve/gve_main.c b/sys/dev/gve/gve_main.c index 0e40656ca928..c726177c199c 100644 --- a/sys/dev/gve/gve_main.c +++ b/sys/dev/gve/gve_main.c @@ -196,6 +196,8 @@ static int gve_set_mtu(if_t ifp, uint32_t new_mtu) { struct gve_priv *priv = if_getsoftc(ifp); + const uint32_t max_problem_range = 8227; + const uint32_t min_problem_range = 7822; int err; if ((new_mtu > priv->max_mtu) || (new_mtu < ETHERMIN)) { @@ -204,6 +206,19 @@ gve_set_mtu(if_t ifp, uint32_t new_mtu) return (EINVAL); } + /* + * When hardware LRO is enabled in DQ mode, MTUs within the range + * [7822, 8227] trigger hardware issues which cause a drastic drop + * in throughput. + */ + if (!gve_is_gqi(priv) && !gve_disable_hw_lro && + new_mtu >= min_problem_range && new_mtu <= max_problem_range) { + device_printf(priv->dev, + "Cannot set to MTU to %d within the range [%d, %d] while hardware LRO is enabled\n", + new_mtu, min_problem_range, max_problem_range); + return (EINVAL); + } + err = gve_adminq_set_mtu(priv, new_mtu); if (err == 0) { if (bootverbose)