From owner-svn-src-all@FreeBSD.ORG Wed Sep 15 03:29:46 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 053CB106564A; Wed, 15 Sep 2010 03:29:46 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout026.mac.com (asmtpout026.mac.com [17.148.16.101]) by mx1.freebsd.org (Postfix) with ESMTP id DF8CF8FC0C; Wed, 15 Sep 2010 03:29:45 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii Received: from [192.168.2.104] (hob.xcllnt.net [70.36.220.6]) by asmtp026.mac.com (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTPSA id <0L8R007CDO99VU60@asmtp026.mac.com>; Tue, 14 Sep 2010 19:29:35 -0700 (PDT) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=6.0.2-1004200000 definitions=main-1009140168 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.0.10011,1.0.148,0.0.0000 definitions=2010-09-14_15:2010-09-14, 2010-09-14, 1970-01-01 signatures=0 From: Marcel Moolenaar In-reply-to: <201009141621.o8EGLDhr086248@svn.freebsd.org> Date: Tue, 14 Sep 2010 19:29:32 -0700 Message-id: References: <201009141621.o8EGLDhr086248@svn.freebsd.org> To: Pawel Jakub Dawidek X-Mailer: Apple Mail (2.1081) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212614 - in head: sbin/geom/class/part sys/geom/part X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 03:29:46 -0000 On Sep 14, 2010, at 9:21 AM, Pawel Jakub Dawidek wrote: > Author: pjd > Date: Tue Sep 14 16:21:13 2010 > New Revision: 212614 > URL: http://svn.freebsd.org/changeset/base/212614 > > Log: > - Change all places where G_TYPE_ASCNUM is used to G_TYPE_NUMBER. > It turns out the new type wasn't really needed. > - Reorganize code a little bit. Please revert. The gpart ctlreq interface is ASCII only by design. This change is unnecessary as nothing was broken and on top of that breaks compatibility with user-space -- again entirely without merit. Thanks, -- Marcel Moolenaar xcllnt@mac.com