From owner-cvs-src@FreeBSD.ORG Fri Aug 1 11:42:48 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E207537B405; Fri, 1 Aug 2003 11:42:47 -0700 (PDT) Received: from ns2.gnf.org (ns2.gnf.org [63.196.132.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id F27A243FA3; Fri, 1 Aug 2003 11:42:45 -0700 (PDT) (envelope-from gtetlow@gnf.org) Received: from EXCHCLUSTER01.lj.gnf.org (exch02.lj.gnf.org [172.25.10.20]) by ns2.gnf.org (8.12.8p1/8.12.8) with ESMTP id h71Ighoq064723; Fri, 1 Aug 2003 11:42:43 -0700 (PDT) (envelope-from gtetlow@gnf.org) Received: from roark.gnf.org ([172.25.24.15]) by EXCHCLUSTER01.lj.gnf.org with Microsoft SMTPSVC(5.0.2195.5329); Fri, 1 Aug 2003 11:42:45 -0700 Received: from roark.gnf.org (localhost [127.0.0.1]) by roark.gnf.org (8.12.9/8.12.9) with ESMTP id h71Igii2048356; Fri, 1 Aug 2003 11:42:45 -0700 (PDT) (envelope-from gtetlow@gnf.org) Received: (from gtetlow@localhost) by roark.gnf.org (8.12.9/8.12.9/Submit) id h71IgiCB048355; Fri, 1 Aug 2003 11:42:44 -0700 (PDT) Date: Fri, 1 Aug 2003 11:42:43 -0700 From: Gordon Tetlow To: Bruce Evans Message-ID: <20030801184243.GT12582@roark.gnf.org> References: <200308010904.h7194W4a061763@repoman.freebsd.org> <20030802000356.P1436@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="53TzBEXPl5+8hjUY" Content-Disposition: inline In-Reply-To: <20030802000356.P1436@gamplex.bde.org> User-Agent: Mutt/1.4i X-Habeas-SWE-1: winter into spring X-Habeas-SWE-2: brightly anticipated X-Habeas-SWE-3: like Habeas SWE (tm) X-Habeas-SWE-4: Copyright 2002 Habeas (tm) X-Habeas-SWE-5: Sender Warranted Email (SWE) (tm). The sender of this X-Habeas-SWE-6: email in exchange for a license for this Habeas X-Habeas-SWE-7: warrant mark warrants that this is a Habeas Compliant X-Habeas-SWE-8: Message (HCM) and not spam. Please report use of this X-Habeas-SWE-9: mark in spam to . X-OriginalArrivalTime: 01 Aug 2003 18:42:45.0676 (UTC) FILETIME=[B2D0A6C0:01C3585C] cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/rescue/rescue Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2003 18:42:48 -0000 --53TzBEXPl5+8hjUY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 02, 2003 at 12:11:56AM +1000, Bruce Evans wrote: > On Fri, 1 Aug 2003, Gordon Tetlow wrote: >=20 > > gordon 2003/08/01 02:04:32 PDT > > > > FreeBSD src repository > > > > Modified files: > > rescue/rescue Makefile > > Log: > > When using crunchgen, blow away MAKEFLAGS. This fixes make -j <#> -P > > from passing the -P flag to crunchgen which seems to confuse crunchgen > > horribly. >=20 > Doesn't also prevent make -j <#> -P from passing the -j <#> flag and any > other useful flags that may be in MAKEFLAGS? That's true, but it's only on a single invocation of crunchgen. I should have been more clear in my commit message. > > This is the preferable solution to modifing crunchgen to > > unset the MAKEFLAGS environment variable. >=20 > Certainly, since unsetting MAKEFLAGS very generally would be more likely > to lose something important in it. >=20 > Setting MAKEFLAGS to ${MAKEFLAGS:N-P} might be safe enough to do generall= y. I'll test out this solution. There are other flags that are potentially dangerous (perhaps -v, although I haven't tested it to see if it causes problems). -gordon --53TzBEXPl5+8hjUY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/KrSjRu2t9DV9ZfsRAojiAKCzOrAvVW74pcAZTPwfL4XsJ2XyMACfU7Jq EPHZ32o0hrVQdk7Rv2ou6IA= =Cz2w -----END PGP SIGNATURE----- --53TzBEXPl5+8hjUY--