From owner-freebsd-bugs@FreeBSD.ORG Sun Jun 1 05:30:12 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2332106567D for ; Sun, 1 Jun 2008 05:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CCF7C8FC0C for ; Sun, 1 Jun 2008 05:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m515UCHE089166 for ; Sun, 1 Jun 2008 05:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m515UCjP089165; Sun, 1 Jun 2008 05:30:12 GMT (envelope-from gnats) Date: Sun, 1 Jun 2008 05:30:12 GMT Message-Id: <200806010530.m515UCjP089165@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Matthew Luckie Cc: Subject: Re: bin/123807: [patch] timed does not run on arm (incorrect getopt usage) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthew Luckie List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jun 2008 05:30:13 -0000 The following reply was made to PR bin/123807; it has been noted by GNATS. From: Matthew Luckie To: Giorgos Keramidas Cc: bug-followup@freebsd.org Subject: Re: bin/123807: [patch] timed does not run on arm (incorrect getopt usage) Date: Sun, 01 Jun 2008 17:23:33 +1200 > The first hunk of the patch looks ok, but do we really need the second > one too? There are far too many places where an `int' return from > getopt() is compared with '?'-style characters in switch(), so if we > don't need it let's not add a cast. you're right, the cast is not required.