From owner-svn-src-all@freebsd.org Wed Sep 25 12:57:16 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DF6EF126443; Wed, 25 Sep 2019 12:57:16 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ddPS5Xp5z3MDm; Wed, 25 Sep 2019 12:57:16 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 962989D28; Wed, 25 Sep 2019 12:57:16 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f175.google.com with SMTP id 3so6392215qta.1; Wed, 25 Sep 2019 05:57:16 -0700 (PDT) X-Gm-Message-State: APjAAAW1b81nbcNTxOq8L7T6eMMw37HSQM8JynIgIAmMps/jIztHebdC 2j6of2UrL49gfee1M9OO+3sV6RVwRAJ/k55V6EA= X-Google-Smtp-Source: APXvYqzbgJoUmRwKOiw9YGZ5INh/lHMNAsAMfr1XNkrCdajpCWA2ZAfM7foUIsiqLax4GRp/ExgtqFJ0xpIISDIplmU= X-Received: by 2002:ac8:5306:: with SMTP id t6mr8642445qtn.53.1569416235825; Wed, 25 Sep 2019 05:57:15 -0700 (PDT) MIME-Version: 1.0 References: <201909250237.x8P2bf0X033449@repo.freebsd.org> <20190925065753.vmw4ls426xighbag@ivaldir.net> In-Reply-To: <20190925065753.vmw4ls426xighbag@ivaldir.net> From: Kyle Evans Date: Wed, 25 Sep 2019 07:57:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r352668 - in head/usr.sbin/cron: cron crontab lib To: Baptiste Daroussin Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2019 12:57:16 -0000 On Wed, Sep 25, 2019 at 1:58 AM Baptiste Daroussin wrote: > > On Wed, Sep 25, 2019 at 02:37:41AM +0000, Kyle Evans wrote: > > Author: kevans > > Date: Wed Sep 25 02:37:40 2019 > > New Revision: 352668 > > URL: https://svnweb.freebsd.org/changeset/base/352668 > > > > Log: > > cron: add log suppression and mail suppression for successful runs > > > > This commit adds two new extensions to crontab, ported from OpenBSD: > > - -n: suppress mail on succesful run > > - -q: suppress logging of command execution > > > > The -q option appears decades old, but -n is relatively new. The > > original proposal by Job Snijder can be found here [1], and gives very > > convincing reasons for inclusion in base. > > > > This patch is a nearly identical port of OpenBSD cron for -q and -n > > features. It is written to follow existing conventions and style of the > > existing codebase. > > > > Example usage: > > > > # should only send email, but won't show up in log > > * * * * * -q date > > > > # should not send email > > * * * * * -n date > > > > # should not send email or log > > * * * * * -n -q date > > > > # should send email because of ping failure > > * * * * * -n -q ping -c 1 5.5.5.5 > > > > [1]: https://marc.info/?l=openbsd-tech&m=152874866117948&w=2 > > > > PR: 237538 > > Submitted by: Naveen Nathan > > Reviewed by: bcr (manpages) > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D20046 > > > I do think this deserves an entry in the release notes > Ahh, I'm inclined to agree. I'll write up a RELNOTES entry here shortly. Thanks, Kyle Evans