Date: Tue, 14 Oct 2008 12:38:54 GMT From: Wojciech Puchar <wojtek@tensor.gdynia.pl> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/128091: zaptel drivers can't be used when asterisk runs as non-root Message-ID: <200810141238.m9ECcsU3026302@www.freebsd.org> Resent-Message-ID: <200810141240.m9ECe1Qm098649@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 128091 >Category: ports >Synopsis: zaptel drivers can't be used when asterisk runs as non-root >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Oct 14 12:40:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Wojciech Puchar >Release: RELENG_7 >Organization: TENSOR ap >Environment: FreeBSD wojtek.tensor.gdynia.pl 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Thu Oct 9 21:12:09 CEST 2008 root@wojtek.tensor.gdynia.pl:/usr/src/sys/i386/compile/p234 i386 >Description: zaptel drivers create nodes in /dev/zap owned by root. asterisk can't open it when running as user. >How-To-Repeat: try using zaptel with asterisk running as non-root >Fix: yes. patch Makefile (/usr/ports/misc/zaptel) with that: --- Makefile.orig 2008-08-15 20:48:56.000000000 +0200 +++ Makefile 2008-10-14 14:23:06.000000000 +0200 @@ -24,6 +24,15 @@ MAKE_ENV= KMODDIR=${PREFIX}/lib/zaptel SUB_FILES= pkg-message USE_RC_SUBR= zaptel +EXTRA_PATCHES+= ${PATCHDIR}/uidgid + +.if defined(ZAP_UID) +MAKE_ARGS+= ZAP_UID=${ZAP_UID} +.endif + +.if defined(ZAP_GID) +MAKE_ARGS+= ZAP_GID=${ZAP_GID} +.endif .include <bsd.port.pre.mk> and make file files/uidgid containing: --- zaptel/Makefile~ 2008-10-14 14:28:49.000000000 +0200 +++ zaptel/Makefile 2008-10-14 14:28:49.000000000 +0200 @@ -6,6 +6,18 @@ # CFLAGS+=-g CLEANFILES+=gendigits tones.h WERROR=-Wall +.if defined(ZAP_UID) +CFLAGS+= -DZAP_UID=${ZAP_UID} +.else +CFLAGS+= -DZAP_UID=0 +.endif + +.if defined(ZAP_GID) +CFLAGS+= -DZAP_GID=${ZAP_GID} +.else +CFLAGS+= -DZAP_GID=0 +.endif + SRCS+=device_if.h bus_if.h vnode_if.h --- zaptel/zaptel.c.orig 2008-10-13 14:30:59.000000000 +0200 +++ zaptel/zaptel.c 2008-10-13 14:31:22.000000000 +0200 @@ -457,7 +457,7 @@ snprintf(tmpname, 20, "%s%d", name, u); *dev = make_dev(&zt_devsw, unit2minor(u), - UID_ROOT, GID_WHEEL, 0600, tmpname); + ZAP_UID, ZAP_GID, 0600, tmpname); if(*dev) { @@ -1233,7 +1233,7 @@ * zt_clone will get "zap" string as name instead of * "zap/timer" or something */ - dev_ctl = make_dev(&zt_devsw, 0, UID_ROOT, GID_WHEEL, 0664, + dev_ctl = make_dev(&zt_devsw, 0, ZAP_UID, ZAP_GID, 0664, "zap/ctl"); printf("Zapata Telephony Interface Registered on major %d\n", this 2 files attached as single .txt file, filter through uudecode|tar xf - Patch attached with submission follows: begin 600 - M'XL(`+^2]$@"`^V6_4_30!C'^;7]*YY,,<.^[/H*3F>8HXP%$-*!&&/2E/76 MG73MTMXD:O!O]^G:$3*&^(M$D_MDV5UZ]WWN>>ESVW%X1<<LH?HLY*/)QE^! M$.+:-N!H;#O6W;'"-2TP#++MX)=CFD`,VW:=#2`;3\"\X&&.KEQG7SB]>GC? M8^M5*'`[_B=HF@;'RW<@RUDLF83L:/@Q'#!)V]YI.ZZ^K!0!A>"ZK"C*K:H2 M&$0S;##LMFFUR7W![BYHIJVZH.`W6M[=E>&X>^@%WOL/'>GP^&1O;^!WGO\X M];W]P<>;5L(N6]_#&:>)#,/S=\'^X,@;=J395:Q-:5&$,97A?.@%?B_`9;\C MU9L5[^.9WPU.NV>]`V^H=`!-EG.T?M.:LRAFD:S(BL[&$*'W*8V:G[JGP?E@ M;TM6%@YU_3[JI/HINE3/;E!%TXB-U^G[:_7]6WW_KAYDT%DZ2N81A3>71:3/ MLISKLYSJTZNWN/JD]:]R\G?/>*3_3>(8M_UO6B[VOV48KNC_I^K_JG=:RX;^ MN=K1.VW[U=HK8$7X1[KR)G#+B\!5C9W%/?`,>OM'W;)KM%B&WI'7?;]H=Z43 MEPT3,UX`SU):Z!,9+CS?/_$[VD68)`_U\=(<:'OKVS@IZ-I=Y/$>7U'=;_%U MMOLKMO$&&/H]7(_H5S:B`1OK$[B<%]7D:YI%U3/<>*<^U:"/[ES39:ZM,M<6 M:3N_K=%2O*HSVJ:YMD:VLZUN@U(-99FD(IWE+.7C)I_.TG!*5?Q]4*&Q66Q& M#16J)_.MUV5TTDN,##HPQ3<CP&GSQ7=>CL4U;DD9-Z<LS?+F?$N5-4G"U`?^ MR<F9"IBHX.+`\XY4("Y!Z_51:%61EG>R"G5.[V\JCV;C9GGZ%DY_+"(Q3,LJ M0ZG'12P2O`1T:93@>P77+$D@IAP:F*4&%!S#C"$L%C$!2PM.PPBR,=3"<EN+ MLRG-&Y#E4&13RB<HJ99;94CH0##BR0,I0)\?B-FU52A#?52_+A<+,?J`7D#E M))IHU&F1ZN(U/H7X5R^$,YK0V21+O\$@Y30?AR,*/HT9!IM3C#;%D[]@=)O1 JYQ3+*V\(!`*!0"`0"`0"@4`@$`@$`H%`(!`(!`*!X%_F%T5`&T\`*``` ` end >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810141238.m9ECcsU3026302>