Date: Sun, 06 Oct 2013 14:39:09 -0700 From: Sean Bruno <sean_bruno@yahoo.com> To: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: drm2/radeon dfixed_trunc() warnings Message-ID: <1381095549.1586.7.camel@localhost>
next in thread | raw e-mail | index | archive | help
--=-rgtCoYwmDgK4fOHKYw7y
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
These caught my eye today, and the checks strewn about
sys/dev/drm2/radeon seem completely bogus to me, but I don't have the
h/w to test it at the moment.
/usr/src/sys/modules/drm2/radeonkms/../../../dev/drm2/radeon/rs690.c:491:37=
: warning: comparison of unsigned expression < 0 is always false [-Wtautolo=
gical-compare]
if (dfixed_trunc(priority_mark02) < 0)
dfixed_trunc is a macro:
drm_fixed.h:#define dfixed_trunc(A) ((A).full >> 12)
that returns the output of a shift right operation ... priority_mark02
is of type union fixed20_12, single element union of type u32, so I
can't see this check ever doing anything useful.
But, as always, I'm probably missing something obvious. =20
Sean
--=-rgtCoYwmDgK4fOHKYw7y
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (FreeBSD)
iQEcBAABAgAGBQJSUdh5AAoJEBkJRdwI6BaHMXoH/2a5cP+Wo/00dPi//49N/Jqq
jzd1UE3Fy2ZAIsesPmSMMmY3i2ZnvcTFrhrXYuAIoviagREd24SEATm98SHNpOO2
Q4LmnQ2oSMBvoERA/ORnKqG6hPUNAl2WshfpC6OA/1DToy8mN58/moX1jQNNbO3d
ulFKW1kTsXTf4LQmspGl0lcytVoONVfk3RY6FXzUKnYJ84VQ0C04Ya987hV3vwjZ
3kg7dgYqhqCELSzxh+XGznPb8iBk+9mYrs3d8oe6X/m694opVaohPQr7nrUFdH70
oIGcaUhn5Lny9yYt+VYcvAh9XZh9JHwIy9r4LPk4avJNJaPqksEef0oNayzglBE=
=zlR4
-----END PGP SIGNATURE-----
--=-rgtCoYwmDgK4fOHKYw7y--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1381095549.1586.7.camel>