From owner-svn-src-head@FreeBSD.ORG Sun Apr 15 02:38:02 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 36D1C106564A; Sun, 15 Apr 2012 02:38:02 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 21EC48FC0A; Sun, 15 Apr 2012 02:38:02 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q3F2c1Fb060786; Sun, 15 Apr 2012 02:38:01 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q3F2c1Hh060784; Sun, 15 Apr 2012 02:38:01 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201204150238.q3F2c1Hh060784@svn.freebsd.org> From: Adrian Chadd Date: Sun, 15 Apr 2012 02:38:01 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r234306 - head/sys/mips/atheros X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Apr 2012 02:38:02 -0000 Author: adrian Date: Sun Apr 15 02:38:01 2012 New Revision: 234306 URL: http://svn.freebsd.org/changeset/base/234306 Log: Fix the mask logic when reading PCI configuration space registers. Modified: head/sys/mips/atheros/ar71xx_pci.c Modified: head/sys/mips/atheros/ar71xx_pci.c ============================================================================== --- head/sys/mips/atheros/ar71xx_pci.c Sun Apr 15 01:40:22 2012 (r234305) +++ head/sys/mips/atheros/ar71xx_pci.c Sun Apr 15 02:38:01 2012 (r234306) @@ -204,8 +204,12 @@ ar71xx_pci_read_config(device_t dev, u_i /* register access is 32-bit aligned */ shift = (reg & 3) * 8; - if (shift) - mask = (1 << shift) - 1; + + /* Create a mask based on the width, post-shift */ + if (bytes == 2) + mask = 0xffff; + else if (bytes == 1) + mask = 0xff; else mask = 0xffffffff;