Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Apr 2000 23:19:01 -0400 (EDT)
From:      Luoqi Chen <luoqi@watermarkgroup.com>
To:        mihara@prd.fc.nec.co.jp
Cc:        freebsd-smp@FreeBSD.ORG, smp@csn.net
Subject:   Re: Multiple APIC support (RE: Issues with Spankin' new Poweredge 4400 w/ dual 866's and 133MHz FSB?)
Message-ID:  <200004200319.XAA26909@lor.watermarkgroup.com>

next in thread | raw e-mail | index | archive | help
> Thank you for the patch, but applying your patch results in panic
> while booting, just after showing avail memory.  Here is the boot log.
> (Even if second IO-APIC is disabled, the phenomenon is same.)
> 
My fault, I made a mistake in the patch. Here's the correct one
(the offset should be added before typecasting),

Index: pmap.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/i386/pmap.c,v
retrieving revision 1.252
diff -u -r1.252 pmap.c
--- pmap.c	2000/03/16 08:51:49	1.252
+++ pmap.c	2000/04/20 03:14:48
@@ -426,9 +426,10 @@
 		for (j = 0; j < mp_napics; j++) {
 			/* same page frame as a previous IO apic? */
 			if (((vm_offset_t)SMPpt[NPTEPG-2-j] & PG_FRAME) ==
-			    (io_apic_address[0] & PG_FRAME)) {
+			    (io_apic_address[i] & PG_FRAME)) {
 				ioapic[i] = (ioapic_t *)((u_int)SMP_prvspace
-					+ (NPTEPG-2-j)*PAGE_SIZE);
+					+ (NPTEPG-2-j)*PAGE_SIZE
+					+ (io_apic_address[i] & PAGE_MASK));
 				break;
 			}
 			/* use this slot if available */
@@ -436,7 +437,8 @@
 				SMPpt[NPTEPG-2-j] = (pt_entry_t)(PG_V | PG_RW |
 				    pgeflag | (io_apic_address[i] & PG_FRAME));
 				ioapic[i] = (ioapic_t *)((u_int)SMP_prvspace
-					+ (NPTEPG-2-j)*PAGE_SIZE);
+					+ (NPTEPG-2-j)*PAGE_SIZE
+					+ (io_apic_address[i] & PAGE_MASK));
 				break;
 			}
 		}


-lq


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-smp" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200004200319.XAA26909>